Bug 191381

Summary:

[iOS] Option + Delete should delete previous word

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Platform

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

megan_gardner, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 12

See Also:

https://bugs.webkit.org/show_bug.cgi?id=191389

Bug Depends on:

Bug Blocks:

190571

Attachments:

Description	Flags
Patch	none
Patch	none

Description Daniel Bates 2018-11-07 10:05:30 PST

We should recognize the key command Option + Delete and delete the previous word to more closely match iOS platform conventions.

Comment 1 Daniel Bates 2018-11-07 10:05:48 PST

<rdar://problem/23681351>

Comment 2 Daniel Bates 2018-11-07 10:22:32 PST

Created attachment 354104 [details]
Patch

It is not straightforward to write a test for this change because UIKit determines the modifier keys pressed (e.g. Option) by querying the keyboard directly. We could mock out the underlying keyboard though this seems fragile.

Comment 3 Daniel Bates 2018-11-07 11:37:35 PST

Created attachment 354116 [details]
Patch

Comment 4 Daniel Bates 2018-11-07 14:12:02 PST

Comment on attachment 354116 [details]
Patch

Clearing flags on attachment: 354116

Committed r237943: <https://trac.webkit.org/changeset/237943>

Comment 5 Daniel Bates 2018-11-07 14:12:04 PST

All reviewed patches have been landed.  Closing bug.