Bug 191239

Summary: Cache glyph paths and share underline skipping code between all the ports
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cgarcia, dbates, dino, ews-watchlist, jonlee, koivisto, mcatanzaro, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191630
Bug Depends on:    
Bug Blocks: 190774, 191630    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
achristensen: review+, ews-watchlist: commit-queue-
Patch for committing
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch for committing none

Myles C. Maxfield
Reported 2018-11-04 17:26:27 PST
Cache glyph paths and share underline skipping code between all the ports
Attachments
Patch (40.42 KB, patch)
2018-11-04 17:31 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (37.24 KB, patch)
2018-11-04 18:03 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (37.72 KB, patch)
2018-11-04 18:57 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (37.72 KB, patch)
2018-11-04 19:38 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (40.10 KB, patch)
2018-11-04 22:54 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (41.28 KB, patch)
2018-11-05 09:45 PST, Myles C. Maxfield 		achristensen: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (41.25 KB, patch)
2018-11-05 15:49 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.42 MB, application/zip)
2018-11-05 16:20 PST, EWS Watchlist 		no flags
Details
Patch for committing (41.03 KB, patch)
2018-11-05 16:23 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-11-04 17:31:19 PST
Created attachment 353814 [details] Patch
Myles C. Maxfield
Comment 2 2018-11-04 18:03:09 PST
Created attachment 353816 [details] Patch
Myles C. Maxfield
Comment 3 2018-11-04 18:57:42 PST
Created attachment 353819 [details] Patch
Myles C. Maxfield
Comment 4 2018-11-04 19:38:45 PST
Created attachment 353821 [details] Patch
Myles C. Maxfield
Comment 5 2018-11-04 22:54:22 PST
Created attachment 353830 [details] Patch
Myles C. Maxfield
Comment 6 2018-11-05 09:45:20 PST
Created attachment 353881 [details] Patch
Alex Christensen
Comment 7 2018-11-05 14:44:35 PST
Comment on attachment 353881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353881&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:1241 > +enum class GlyphUnderlineType { : uint8_t > Source/WebCore/platform/graphics/FontCascade.cpp:1669 > + GlyphIterationState(FloatPoint startingPoint, FloatPoint currentPoint, float y1, float y2, float minX, float maxX) It seems like this constructor could be omitted by using an initializer list where this constructor is called.
Myles C. Maxfield
Comment 8 2018-11-05 15:49:58 PST
Created attachment 353916 [details] Patch for committing
EWS Watchlist
Comment 9 2018-11-05 16:19:58 PST
Comment on attachment 353881 [details] Patch Attachment 353881 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9870516 New failing tests: imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html
EWS Watchlist
Comment 10 2018-11-05 16:20:00 PST
Created attachment 353920 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Myles C. Maxfield
Comment 11 2018-11-05 16:23:19 PST
Created attachment 353921 [details] Patch for committing
Myles C. Maxfield
Comment 12 2018-11-05 20:36:06 PST
Committed r237845: <https://trac.webkit.org/changeset/237845>
Radar WebKit Bug Importer
Comment 13 2018-11-05 20:37:21 PST
<rdar://problem/45831149>
Michael Catanzaro
Comment 14 2018-11-16 10:36:38 PST
It broke the underscore beneath hyperlinks, bug #191630.
Carlos Garcia Campos
Comment 15 2018-11-19 01:43:58 PST
Comment on attachment 353881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353881&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:1751 > + , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()).scale(1, -1)) This is what broke cairo ports, we didn't have that scale(1, -1) in the cairo impl.
Note You need to log in before you can comment on or make changes to this bug.