| Summary: | Web Inspector: Network Graphs are missing minimum sizes, might have no graph at all | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 197220 | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 353728 [details]
[IMAGE] Original Network Tab
Created attachment 353729 [details]
[IMAGE] Current Network Tab
Notice how before, even if the load was 0ms there was still a minimum appearance. That has gone away. I feel this is a regression in the user experience, as you still want to see _when_ the load happened, even if it took effectively no time. Created attachment 354581 [details]
Patch
Comment on attachment 354581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354581&action=review r=me > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:793 > + if (endTimestamp - startTimestamp < 0) > + return null; When can this happen? Created attachment 354780 [details]
Patch
Comment on attachment 354780 [details] Patch Clearing flags on attachment: 354780 Committed r238168: <https://trac.webkit.org/changeset/238168> All reviewed patches have been landed. Closing bug. |
Created attachment 353727 [details] [IMAGE] Issue Network Graphs are missing minimum sizes, might have no graph at all Steps to Reproduce: 1. Inspect webkit.org 2. Ensure you're using the network cache 3. Reload the page => Some rows are blank, unclear where to click to get resource load timings / details