Bug 191208

Summary: Web Inspector: Network Graphs are missing minimum sizes, might have no graph at all
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 197220    
Attachments:
Description Flags
[IMAGE] Issue
none
[IMAGE] Original Network Tab
none
[IMAGE] Current Network Tab
none
Patch
none
Patch none

Joseph Pecoraro
Reported 2018-11-02 14:20:22 PDT
Created attachment 353727 [details] [IMAGE] Issue Network Graphs are missing minimum sizes, might have no graph at all Steps to Reproduce: 1. Inspect webkit.org 2. Ensure you're using the network cache 3. Reload the page => Some rows are blank, unclear where to click to get resource load timings / details
Attachments
[IMAGE] Issue (564.21 KB, image/png)
2018-11-02 14:20 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] Original Network Tab (446.89 KB, image/png)
2018-11-02 14:20 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] Current Network Tab (566.60 KB, image/png)
2018-11-02 14:20 PDT, Joseph Pecoraro 		no flags
Details
Patch (15.16 KB, patch)
2018-11-12 13:25 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (15.02 KB, patch)
2018-11-14 00:47 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-11-02 14:20:41 PDT
Created attachment 353728 [details] [IMAGE] Original Network Tab
Joseph Pecoraro
Comment 2 2018-11-02 14:20:54 PDT
Created attachment 353729 [details] [IMAGE] Current Network Tab
Joseph Pecoraro
Comment 3 2018-11-02 14:21:54 PDT
Notice how before, even if the load was 0ms there was still a minimum appearance. That has gone away. I feel this is a regression in the user experience, as you still want to see _when_ the load happened, even if it took effectively no time.
Devin Rousso
Comment 4 2018-11-12 13:25:58 PST
Created attachment 354581 [details] Patch
Joseph Pecoraro
Comment 5 2018-11-12 15:33:14 PST
Comment on attachment 354581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354581&action=review r=me > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:793 > + if (endTimestamp - startTimestamp < 0) > + return null; When can this happen?
Devin Rousso
Comment 6 2018-11-14 00:47:51 PST
Created attachment 354780 [details] Patch
WebKit Commit Bot
Comment 7 2018-11-14 01:26:31 PST
Comment on attachment 354780 [details] Patch Clearing flags on attachment: 354780 Committed r238168: <https://trac.webkit.org/changeset/238168>
WebKit Commit Bot
Comment 8 2018-11-14 01:26:32 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-11-14 01:27:27 PST
<rdar://problem/46056899>
Note You need to log in before you can comment on or make changes to this bug.