Bug 191120

Summary: [iOS] Normalize character string based on key code
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Bug Depends on: 189604, 190487    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Daniel Bates
Reported 2018-10-31 10:40:26 PDT
Following the fix for bug #189604, WebKit always has a key code for special keyboard keys (e.g. page up) and hence we can remove the need to perform string comparison when normalizing character strings.
Attachments
Patch (7.31 KB, patch)
2018-10-31 10:47 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (7.31 KB, patch)
2018-10-31 10:49 PDT, Daniel Bates 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-10-31 10:47:38 PDT
Created attachment 353503 [details] Patch
Daniel Bates
Comment 2 2018-10-31 10:49:01 PDT
Created attachment 353504 [details] Patch
Daniel Bates
Comment 3 2018-11-01 09:27:54 PDT
Patch does not apply because it depends on the patch for bug #190487.
Tim Horton
Comment 4 2018-11-01 16:25:20 PDT
Comment on attachment 353504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353504&action=review > Source/WebCore/platform/ios/WebEvent.mm:127 > +static NSString* normalizedStringWithAppKitCompatibilityMapping(NSString *characters, uint16_t keyCode) Not new, but star's on the wrong side.
Daniel Bates
Comment 5 2018-11-02 10:20:36 PDT
Committed r237739: <https://trac.webkit.org/changeset/237739>
Radar WebKit Bug Importer
Comment 6 2018-11-02 10:21:46 PDT
<rdar://problem/45765479>
Note You need to log in before you can comment on or make changes to this bug.