Bug 191101

Summary: [Win] Use C++14, not C++17
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: New BugsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, pvollan, ross.kirsling, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=185232
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2018-10-30 22:42:51 PDT
[Win] Use C++14, not C++17 Based on the webkit-dev discussion, I'd like to switch Windows port from C++17 to C++14. [webkit-dev] MSVC and the state of C++17 https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html See also: Bug 185232 – [Win] Use C++17 in MSVC
Attachments
Patch (5.27 KB, patch)
2018-10-30 22:54 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-10-30 22:54:59 PDT
Created attachment 353465 [details] Patch
Ross Kirsling
Comment 2 2018-10-30 23:00:01 PDT
Comment on attachment 353465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41 > + std::vector<WKChar> wkCharBuffer(maxSize); Should this be a WTF::Vector instead?
Fujii Hironori
Comment 3 2018-10-30 23:06:33 PDT
Comment on attachment 353465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review >> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41 >> + std::vector<WKChar> wkCharBuffer(maxSize); > > Should this be a WTF::Vector instead? The reason why I don't want to use WTF in MiniBrowser is that I want to use only public API (WK1 and WK2) in MiniBrowser as much as possible. But, this is just my opinion, MiniBrowser is including some WebCore headers. See also Bug 190791.
Fujii Hironori
Comment 4 2018-11-04 20:39:28 PST
Comment on attachment 353465 [details] Patch Clearing flags on attachment: 353465 Committed r237789: <https://trac.webkit.org/changeset/237789>
Fujii Hironori
Comment 5 2018-11-04 20:39:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-04 20:40:19 PST
<rdar://problem/45797939>
Note You need to log in before you can comment on or make changes to this bug.