Bug 190911

Summary: Modernize WebKit nibs and lprojs for localization's sake
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, rdemarest, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-10-25 11:24:08 PDT
Modernize WebKit nibs and lprojs for localization's sake
Attachments
Patch (251.92 KB, patch)
2018-10-25 11:25 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (254.00 KB, patch)
2018-10-25 12:00 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-10-25 11:25:12 PDT
Created attachment 353095 [details] Patch
Tim Horton
Comment 2 2018-10-25 11:25:14 PDT
<rdar://problem/45349466>
Beth Dakin
Comment 3 2018-10-25 11:29:21 PDT
Comment on attachment 353095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353095&action=review > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:-9991 > - Japanese, Is it a problem to remove these other regions?
Tim Horton
Comment 4 2018-10-25 11:59:04 PDT
I don't think so.
Tim Horton
Comment 5 2018-10-25 12:00:31 PDT
Created attachment 353099 [details] Patch
mitz
Comment 6 2018-10-25 12:06:01 PDT
The attached diff appears to confuse the diff prettifier.
mitz
Comment 7 2018-10-25 12:10:09 PDT
(In reply to mitz from comment #6) > The attached diff appears to confuse the diff prettifier. Never mind. Something was broken in my web browser causing the pretty diff to be truncated.
mitz
Comment 8 2018-10-26 11:06:33 PDT
Comment on attachment 353099 [details] Patch rs=me Please use svn (or the commit queue?) to land this so that any now-empty directories are deleted from the repository.
WebKit Commit Bot
Comment 9 2018-10-29 14:22:54 PDT
Comment on attachment 353099 [details] Patch Clearing flags on attachment: 353099 Committed r237566: <https://trac.webkit.org/changeset/237566>
WebKit Commit Bot
Comment 10 2018-10-29 14:22:56 PDT
All reviewed patches have been landed. Closing bug.
Anne van Kesteren
Comment 11 2025-01-20 07:59:49 PST
*** Bug 190639 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.