Bug 19091

Summary:

Update CSS Transforms to latest spec

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED WONTFIX

Severity:

Normal

CC:

bdakin, dino, mitz, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Updated transforms patch	hyatt: review-
adds the new files to non-OSX platforms	none
Transforms patch with all platforms	none
tests computed style of transform	none
tests various transforms	none
sets a transform property to a new cssmatrix	none
tests transitions on transforms	none
Transforms patch	hyatt: review+

Dean Jackson

Reported 2008-05-15 15:19:11 PDT

This is the transforms part of http://bugs.webkit.org/show_bug.cgi?id=19028

Attachments
Updated transforms patch (124.05 KB, patch) 2008-05-15 15:29 PDT, Dean Jackson	hyatt: review-	Details Formatted Diff Diff
adds the new files to non-OSX platforms (7.39 KB, patch) 2008-05-15 17:35 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Transforms patch with all platforms (137.54 KB, patch) 2008-05-19 14:01 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
tests computed style of transform (1.76 KB, text/html) 2008-05-19 14:07 PDT, Dean Jackson	no flags	Details
tests various transforms (1.09 KB, text/html) 2008-05-19 14:09 PDT, Dean Jackson	no flags	Details
sets a transform property to a new cssmatrix (1.06 KB, text/html) 2008-05-19 14:09 PDT, Dean Jackson	no flags	Details
tests transitions on transforms (1.42 KB, text/html) 2008-05-19 14:10 PDT, Dean Jackson	no flags	Details
Transforms patch (137.45 KB, patch) 2008-05-19 16:21 PDT, Dean Jackson	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2008-05-15 15:29:20 PDT

Created attachment 21185 [details] Updated transforms patch > In Transform3D.cpp: > > +Transform3D &Transform3D::function() {} > > Move the & to be with the return value, so: > > Transform3D& Transform3D::function() {} done > In CodeGeneratorObjC.pm: > > I don't understand this: > > - return "CSSValue" if $parent eq "SVGColor"; > + return "CSSValue" if $parent eq "SVGColor" or $parent eq "CSSValueList"; This is needed because the WebKitCSSTransformValue inherits from CSSValueList, which isn't recognised as a base class, and therefore gets Node as a parent. Code comes from Weinig. > In DerivedSources.make: > > VoidCallback \ > + WebKitCSSTransformValue \ > WheelEvent \ > > Double-check if tabs are actually used in that file. Removed, although there are some others in there that are not my fault :) > I see "KeyframeList" in this patch. I think that was unintentional. Can you > remove it? Removed

Dave Hyatt

Comment 2 2008-05-15 15:35:40 PDT

Comment on attachment 21185 [details] Updated transforms patch Only thing left that I see is the need to add new files to other projects to avoid breaking the build when landing. You can edit them all by hand (the others are all text files and easy to patch blind). Windows: WebCore.vcproj/WebCore.vcproj wx: WebCore-sources.bkl GTK: GNUmakefile.am Qt: WebCore.pro

Dean Jackson

Comment 3 2008-05-15 17:35:34 PDT

Created attachment 21189 [details] adds the new files to non-OSX platforms Here are the updated project files.

Dean Jackson

Comment 4 2008-05-19 14:01:03 PDT

Created attachment 21234 [details] Transforms patch with all platforms This includes the IDL files, the JS constructors for use on Window and updates to all the platform build files. Hopefully, this is the real deal, yo!

Dean Jackson

Comment 5 2008-05-19 14:07:25 PDT

Created attachment 21235 [details] tests computed style of transform

Dean Jackson

Comment 6 2008-05-19 14:09:13 PDT

Created attachment 21236 [details] tests various transforms

Dean Jackson

Comment 7 2008-05-19 14:09:52 PDT

Created attachment 21237 [details] sets a transform property to a new cssmatrix

Dean Jackson

Comment 8 2008-05-19 14:10:30 PDT

Created attachment 21238 [details] tests transitions on transforms

Dean Jackson

Comment 9 2008-05-19 16:21:58 PDT

Created attachment 21240 [details] Transforms patch Windows build fixes from aroben.

Dave Hyatt

Comment 10 2008-05-22 14:01:47 PDT

Comment on attachment 21240 [details] Transforms patch r=me

Darin Adler

Comment 11 2008-06-08 13:38:29 PDT

We should assign this to the person who's going to land it. Is that you, Hyatt?

Dean Jackson

Comment 12 2008-07-02 19:22:21 PDT

got stale now split across https://bugs.webkit.org/show_bug.cgi?id=19861 https://bugs.webkit.org/show_bug.cgi?id=19863 https://bugs.webkit.org/show_bug.cgi?id=19864

Note You need to log in before you can comment on or make changes to this bug.