Bug 190732

Summary: clean-webkit pulls in many unnecessary dependencies in webkitpy
Product: WebKit Reporter: Dean Johnson <dean_johnson>
Component: Tools / TestsAssignee: Dean Johnson <dean_johnson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193025    
Attachments:
Description Flags
Patch
none
Patch none

Dean Johnson
Reported 2018-10-18 13:54:31 PDT
Tools/Scripts/clean-webkit pulls in many unnecessary dependencies in webkitpy through creation of the Host object, which starts auto-installing 'bugzilla', 'buildbot' and 'web' packages. These can take a while to install, and are not needed at all if just trying to clean your checkout.
Attachments
Patch (2.96 KB, patch)
2018-10-18 13:59 PDT, Dean Johnson 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2018-10-18 14:18 PDT, Dean Johnson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Johnson
Comment 1 2018-10-18 13:59:05 PDT
Created attachment 352727 [details] Patch
Alexey Proskuryakov
Comment 2 2018-10-18 14:14:17 PDT
Comment on attachment 352727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352727&action=review > Tools/Scripts/webkitpy/common/host.py:63 > + @property > + def bugs(self): > + if not hasattr(self, '_bugs'): > + from webkitpy.common.net import bugzilla > + self._bugs = bugzilla.Bugzilla() > + return self._bugs I think that this would be better with @memoized. @memoized def bugs(self): return bugzilla.Bugzilla()
Alexey Proskuryakov
Comment 3 2018-10-18 14:15:04 PDT
Well, also the import.
Dean Johnson
Comment 4 2018-10-18 14:18:06 PDT
Created attachment 352732 [details] Patch
Dean Johnson
Comment 5 2018-10-18 14:19:24 PDT
Changed to use @memoized. Still need @property to access the functions as if they were a property, to allow class attributes 'bugzilla', 'buildbot', and 'web' to continue being used as they were.
Alexey Proskuryakov
Comment 6 2018-10-18 14:20:51 PDT
Comment on attachment 352732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352732&action=review > Tools/Scripts/webkitpy/common/host.py:58 > + @property Do we need @property here? Looks like @memoized tends to be used without.
Alexey Proskuryakov
Comment 7 2018-10-18 14:21:12 PDT
Saw your explanation now.
WebKit Commit Bot
Comment 8 2018-10-18 15:14:59 PDT
Comment on attachment 352732 [details] Patch Clearing flags on attachment: 352732 Committed r237269: <https://trac.webkit.org/changeset/237269>
WebKit Commit Bot
Comment 9 2018-10-18 15:15:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-10-18 15:15:26 PDT
<rdar://problem/45386267>
Daniel Bates
Comment 11 2018-12-24 18:26:17 PST
(In reply to WebKit Commit Bot from comment #8) > Comment on attachment 352732 [details] > Patch > > Clearing flags on attachment: 352732 > > Committed r237269: <https://trac.webkit.org/changeset/237269> This broke "webkit-patch what-broke". See bug #193025.
Note You need to log in before you can comment on or make changes to this bug.