Bug 190639

Summary:

WebKit project should switch from English.lproj to en.lproj

Product:

WebKit

Reporter:

Remy Demarest <rdemarest>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

achristensen, annevk, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none

Remy Demarest

Reported 2018-10-16 13:59:36 PDT

We should switch WebKit projects from English.lproj, which has been deprecated for a decade, to en.lproj.

Attachments
Patch (293.03 KB, patch) 2018-10-19 17:03 PDT, Remy Demarest	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.32 MB, application/zip) 2018-10-19 18:05 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.93 MB, application/zip) 2018-10-19 18:15 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.56 MB, application/zip) 2018-10-19 18:57 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (3.03 MB, application/zip) 2018-10-19 18:58 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Remy Demarest

Comment 1 2018-10-16 13:59:57 PDT

<rdar://problem/45317521>

Remy Demarest

Comment 2 2018-10-19 17:03:13 PDT

Created attachment 352836 [details] Patch

EWS Watchlist

Comment 3 2018-10-19 17:05:48 PDT

Attachment 352836 [details] did not pass style-queue: ERROR: Source/WebCore/WebCore.xcodeproj/project.pbxproj:31686: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj:111: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Source/WebKit/WebKit.xcodeproj/project.pbxproj:10000: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:3228: developmentRegion is not English. [xcodeproj/settings] [5] Total errors found: 4 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 4 2018-10-19 18:05:39 PDT

Comment on attachment 352836 [details] Patch Attachment 352836 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9672788 New failing tests: media/modern-media-controls/localized-strings/replaced-string.html

EWS Watchlist

Comment 5 2018-10-19 18:05:40 PDT

Created attachment 352842 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-10-19 18:15:11 PDT

Comment on attachment 352836 [details] Patch Attachment 352836 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9672832 New failing tests: media/modern-media-controls/localized-strings/replaced-string.html

EWS Watchlist

Comment 7 2018-10-19 18:15:13 PDT

Created attachment 352844 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-10-19 18:57:28 PDT

Comment on attachment 352836 [details] Patch Attachment 352836 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9673052 New failing tests: media/modern-media-controls/localized-strings/replaced-string.html

EWS Watchlist

Comment 9 2018-10-19 18:57:29 PDT

Created attachment 352846 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 10 2018-10-19 18:58:30 PDT

Comment on attachment 352836 [details] Patch Attachment 352836 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9673050 New failing tests: media/modern-media-controls/localized-strings/replaced-string.html

EWS Watchlist

Comment 11 2018-10-19 18:58:32 PDT

Created attachment 352847 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

Alex Christensen

Comment 12 2021-11-01 12:53:43 PDT

Comment on attachment 352836 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Anne van Kesteren

Comment 13 2025-01-20 07:59:49 PST

*** This bug has been marked as a duplicate of bug 190911 ***

Note You need to log in before you can comment on or make changes to this bug.