Summary: | Add Houdini specs to features.json | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||
Component: | WebCore Misc. | Assignee: | Don Olmstead <don.olmstead> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, joepeck, mmaxfield, simon.fraser, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Don Olmstead
2018-10-11 15:08:05 PDT
Created attachment 352089 [details]
Patch
Attachment 352089 [details] did not pass style-queue:
ERROR: Source/WebCore/features.json:0: The specifications should be sorted alphabetically by name, "HTML5" appears after "Houdini". [json/syntax] [5]
ERROR: Source/WebCore/features.json:0: The feature "Worklets Level 1" has a specification field but no specification of that name exists. [json/syntax] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 352090 [details]
Patch
Comment on attachment 352090 [details] Patch Clearing flags on attachment: 352090 Committed r237057: <https://trac.webkit.org/changeset/237057> All reviewed patches have been landed. Closing bug. Created attachment 352119 [details]
Build fix
Features site isn't parsing the file due to a specification being in a specification. Created attachment 352121 [details]
Fix
The commit-queue encountered the following flaky tests while processing attachment 352121 [details]: compositing/geometry/limit-layer-bounds-opacity-transition.html bug 190507 (authors: danakj@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 352121 [details] Fix Clearing flags on attachment: 352121 Committed r237062: <https://trac.webkit.org/changeset/237062> All reviewed patches have been landed. Closing bug. |