Bug 190494 - Add Houdini specs to features.json
Summary: Add Houdini specs to features.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-11 15:08 PDT by Don Olmstead
Modified: 2018-10-11 19:45 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.21 KB, patch)
2018-10-11 15:13 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (4.19 KB, patch)
2018-10-11 15:21 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Build fix (3.98 KB, patch)
2018-10-11 18:48 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Fix (3.98 KB, patch)
2018-10-11 18:53 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-10-11 15:08:05 PDT 
Add the rest of the houdini specifications that are still being developed and group them together.
Comment 1 Don Olmstead 2018-10-11 15:13:01 PDT 
Created attachment 352089 [details]
Patch
Comment 2 EWS Watchlist 2018-10-11 15:17:32 PDT 
Attachment 352089 [details] did not pass style-queue:


ERROR: Source/WebCore/features.json:0:  The specifications should be sorted alphabetically by name, "HTML5" appears after "Houdini".  [json/syntax] [5]
ERROR: Source/WebCore/features.json:0:  The feature "Worklets Level 1" has a specification field but no specification of that name exists.  [json/syntax] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-10-11 15:21:09 PDT 
Created attachment 352090 [details]
Patch
Comment 4 WebKit Commit Bot 2018-10-11 17:08:46 PDT 
Comment on attachment 352090 [details]
Patch

Clearing flags on attachment: 352090

Committed r237057: <https://trac.webkit.org/changeset/237057>
Comment 5 WebKit Commit Bot 2018-10-11 17:08:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-11 17:09:35 PDT 
<rdar://problem/45211879>
Comment 7 Don Olmstead 2018-10-11 18:48:43 PDT 
Created attachment 352119 [details]
Build fix
Comment 8 Don Olmstead 2018-10-11 18:53:01 PDT 
Features site isn't parsing the file due to a specification being in a specification.
Comment 9 Don Olmstead 2018-10-11 18:53:36 PDT 
Created attachment 352121 [details]
Fix
Comment 10 WebKit Commit Bot 2018-10-11 19:44:41 PDT 
The commit-queue encountered the following flaky tests while processing attachment 352121 [details]:

compositing/geometry/limit-layer-bounds-opacity-transition.html bug 190507 (authors: danakj@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2018-10-11 19:45:33 PDT 
Comment on attachment 352121 [details]
Fix

Clearing flags on attachment: 352121

Committed r237062: <https://trac.webkit.org/changeset/237062>
Comment 12 WebKit Commit Bot 2018-10-11 19:45:35 PDT 
All reviewed patches have been landed.  Closing bug.