Bug 190200

Summary:

-Wunused-variable in RenderLayer::updateScrollableAreaSet

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebCore Misc.

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bugs-noreply, commit-queue, mcatanzaro, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

OS:

Linux

See Also:

https://bugs.webkit.org/show_bug.cgi?id=190197

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Michael Catanzaro

Reported 2018-10-02 08:46:13 PDT

We have an unused variable in RenderLayer::updateScrollableAreaSet. I fixed it in r236719 but that broke a bunch of scrolling tests (bug #190197), so clearly I'm not competent enough to do this unreviewed. Let's try again.

Attachments
Patch (1.48 KB, patch) 2018-10-02 09:10 PDT, Michael Catanzaro	no flags	Details Formatted Diff Diff
Patch (2.39 KB, patch) 2018-10-02 10:24 PDT, Michael Catanzaro	no flags	Details Formatted Diff Diff
Patch (2.41 KB, patch) 2018-10-03 01:06 PDT, Michael Catanzaro	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2018-10-02 09:10:30 PDT

Created attachment 351394 [details] Patch

Alex Christensen

Comment 2 2018-10-02 10:02:20 PDT

Comment on attachment 351394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351394&action=review > Source/WebCore/rendering/RenderLayer.cpp:6369 > + // Silence -Wunused-variable. The UNUSED_PARAM macro would work here, but the naming would be > + // off as it's not a parameter. This comment seems excessively verbose. Why not just use UNUSED_PARAM like we do in many other places, or make an UNUSED_VARIABLE macro?

Michael Catanzaro

Comment 3 2018-10-02 10:20:51 PDT

My vote is to make UNUSED_VARIABLE() in Compiler.h

Michael Catanzaro

Comment 4 2018-10-02 10:24:31 PDT

Did not build this yet... let's see if it passes EWS.

Michael Catanzaro

Comment 5 2018-10-02 10:24:48 PDT

Created attachment 351413 [details] Patch

Michael Catanzaro

Comment 6 2018-10-03 00:56:53 PDT

(In reply to Michael Catanzaro from comment #4) > Did not build this yet... let's see if it passes EWS. Signs point to "no."