Bug 190165

Summary: Web Inspector: move frontend managers to a container object
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: NEW    
Severity: Normal CC: bburg, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190160, 190161, 190162    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch bburg: review-

Devin Rousso
Reported 2018-10-01 14:39:45 PDT
Instead of having each manager's instance be a camel-cased object on `WI`, we should have a container for all manager objects (e.g. `WI.Manager.Foo`).
Attachments
Patch (955.92 KB, patch)
2018-10-02 16:12 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (709.88 KB, patch)
2018-10-04 23:41 PDT, Devin Rousso 		bburg: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-10-02 12:14:46 PDT
(In reply to Devin Rousso from comment #0) > Instead of having each manager's instance be a camel-cased object on `WI`, > we should have a container for all manager objects (e.g. `WI.Manager.Foo`). The direction I started on was WI.sharedApp.fooManager, but I ran out of time for refactoring. I suggest you hang the instances off of WI.sharedApp. Joe will probably need to adjust this soon anyway.
Devin Rousso
Comment 2 2018-10-02 16:12:21 PDT
Created attachment 351450 [details] Patch
Devin Rousso
Comment 3 2018-10-04 23:41:05 PDT
Created attachment 351659 [details] Patch This is in no rush to land, but I think it might help Joe with some of his work
Blaze Burg
Comment 4 2018-10-08 09:31:02 PDT
(In reply to Devin Rousso from comment #3) > Created attachment 351659 [details] > Patch > > This is in no rush to land, but I think it might help Joe with some of his > work This seem to go further down the path of making everything a singleton, which I believe is not what we want.
Devin Rousso
Comment 5 2018-10-08 09:49:11 PDT
(In reply to Brian Burg from comment #4) > (In reply to Devin Rousso from comment #3) > > Created attachment 351659 [details] > > Patch > > > > This is in no rush to land, but I think it might help Joe with some of his > > work > > This seem to go further down the path of making everything a singleton, > which I believe is not what we want. Actually, this is meant to "centralize" all the managers into a more obvious place. Additionally, this will be used by some of the stuff Joe's working on and may make his work easier.
Blaze Burg
Comment 6 2018-10-31 09:20:19 PDT
Comment on attachment 351659 [details] Patch Marking r- as this conflicts with Joe's rearchitecture patches. Let's revisit this when the relevant frontend changes are finished (in particular, fixing un-targeted agent accesses).
Note You need to log in before you can comment on or make changes to this bug.