Bug 190162

Summary: Web Inspector: remove analyzer manager
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 190165    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2018-10-01 14:26:46 PDT
This manager is never used.
Attachments
Patch (9.99 KB, patch)
2018-10-01 14:51 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (620.71 KB, patch)
2018-10-01 15:01 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (622.24 KB, patch)
2018-10-01 18:31 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-01 14:51:55 PDT
Created attachment 351308 [details] Patch
Joseph Pecoraro
Comment 2 2018-10-01 15:00:29 PDT
Comment on attachment 351308 [details] Patch r-, so that we can remove eslint.js as well. We strip it in optimized builds because we aren't using it, but lets just remove it at this point. It has probably gotten pretty stale in the years its been unused.
Devin Rousso
Comment 3 2018-10-01 15:01:59 PDT
Created attachment 351311 [details] Patch
Joseph Pecoraro
Comment 4 2018-10-01 15:08:47 PDT
Comment on attachment 351311 [details] Patch You need to update: WebKit/InspectorGResources.cmake 11: ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/ESLint/*.js r=me
Joseph Pecoraro
Comment 5 2018-10-01 15:11:42 PDT
Also to ensure this directory gets removed: Source/WebInspectorUI/UserInterface/External/ESLint I think you will want to ensure you have the following in your git configuration: [svn] rmdir = true I'm not sure if commit-queue figures this out or not, or if it makes git patches differ, but generally this is needed if landing manually: https://git-scm.com/docs/git-svn#git-svn---rmdir
Matt Baker
Comment 6 2018-10-01 15:50:14 PDT
(In reply to Joseph Pecoraro from comment #5) > Also to ensure this directory gets removed: > > Source/WebInspectorUI/UserInterface/External/ESLint > > I think you will want to ensure you have the following in your git > configuration: > > [svn] > rmdir = true > > I'm not sure if commit-queue figures this out or not, or if it makes git > patches differ, but generally this is needed if landing manually: > https://git-scm.com/docs/git-svn#git-svn---rmdir Nice tip! I was not aware of this.
Devin Rousso
Comment 7 2018-10-01 18:31:43 PDT
Created attachment 351333 [details] Patch
WebKit Commit Bot
Comment 8 2018-10-01 19:27:23 PDT
Comment on attachment 351333 [details] Patch Clearing flags on attachment: 351333 Committed r236709: <https://trac.webkit.org/changeset/236709>
WebKit Commit Bot
Comment 9 2018-10-01 19:27:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-10-01 19:28:23 PDT
<rdar://problem/44929189>
Note You need to log in before you can comment on or make changes to this bug.