Bug 190150

Summary: [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, graouts, Hironori.Fujii, pvollan, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190032    
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2018-10-01 11:40:48 PDT
[Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
Attachments
Patch (1.57 KB, patch)
2018-10-01 11:42 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-10-01 11:42:03 PDT
Created attachment 351280 [details] Patch
Fujii Hironori
Comment 2 2018-10-01 18:04:52 PDT
Mac port DRT has more options. Don't you need them? https://github.com/WebKit/webkit/blob/234976b18c6973855fa27c50eea2070878ea1488/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L998
Ross Kirsling
Comment 3 2018-10-01 19:38:44 PDT
(In reply to Fujii Hironori from comment #2) > Mac port DRT has more options. Don't you need them? > https://github.com/WebKit/webkit/blob/ > 234976b18c6973855fa27c50eea2070878ea1488/Tools/DumpRenderTree/mac/ > DumpRenderTree.mm#L998 Hmm, it would certainly seem like it, but evidently none of the other options currently have setters available in IWebPreferencesPrivate.idl: https://github.com/WebKit/webkit/blob/master/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl So I suppose it'd be better to add them in the future, if we ever end up needing them in WKL.
WebKit Commit Bot
Comment 4 2018-10-01 22:24:51 PDT
Comment on attachment 351280 [details] Patch Clearing flags on attachment: 351280 Committed r236712: <https://trac.webkit.org/changeset/236712>
WebKit Commit Bot
Comment 5 2018-10-01 22:24:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-01 22:25:25 PDT
<rdar://problem/44931046>
Note You need to log in before you can comment on or make changes to this bug.