| Summary: | [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dino, graouts, Hironori.Fujii, pvollan, tsavell, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 190032 | ||||||
| Attachments: |
|
||||||
|
Description
Ross Kirsling
2018-10-01 11:40:48 PDT
Created attachment 351280 [details]
Patch
Mac port DRT has more options. Don't you need them? https://github.com/WebKit/webkit/blob/234976b18c6973855fa27c50eea2070878ea1488/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L998 (In reply to Fujii Hironori from comment #2) > Mac port DRT has more options. Don't you need them? > https://github.com/WebKit/webkit/blob/ > 234976b18c6973855fa27c50eea2070878ea1488/Tools/DumpRenderTree/mac/ > DumpRenderTree.mm#L998 Hmm, it would certainly seem like it, but evidently none of the other options currently have setters available in IWebPreferencesPrivate.idl: https://github.com/WebKit/webkit/blob/master/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl So I suppose it'd be better to add them in the future, if we ever end up needing them in WKL. Comment on attachment 351280 [details] Patch Clearing flags on attachment: 351280 Committed r236712: <https://trac.webkit.org/changeset/236712> All reviewed patches have been landed. Closing bug. |