Bug 190097

Summary: Skip debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain()
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=190055
Attachments:
Description Flags
Patch none

Description John Wilander 2018-09-28 15:35:40 PDT
The change in https://bugs.webkit.org/show_bug.cgi?id=190055 causes a re-classification that may trigger a debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain(). We should skip the assertion for statistics model version 14.
Comment 1 Radar WebKit Bug Importer 2018-09-28 15:36:14 PDT
<rdar://problem/44877080>
Comment 2 John Wilander 2018-09-28 15:40:26 PDT
Created attachment 351127 [details]
Patch
Comment 3 John Wilander 2018-09-28 18:11:06 PDT
Comment on attachment 351127 [details]
Patch

Thanks, Chris! The iOS-sim bot seems to have unrelated issues.
Comment 4 WebKit Commit Bot 2018-09-28 18:36:34 PDT
Comment on attachment 351127 [details]
Patch

Clearing flags on attachment: 351127

Committed r236630: <https://trac.webkit.org/changeset/236630>
Comment 5 WebKit Commit Bot 2018-09-28 18:36:35 PDT
All reviewed patches have been landed.  Closing bug.