Summary: | Add yasm as third party tool for libwebrtc compilation | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, eric.carlson, ews-watchlist, Hironori.Fujii, realdawei, rniwa, simon.fraser, webkit-bug-importer, youennf | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=186624 https://bugs.webkit.org/show_bug.cgi?id=190102 |
||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 189976 | ||||||||||||||||
Attachments: |
|
Description
youenn fablet
2018-09-26 21:18:09 PDT
Created attachment 350936 [details]
patch
Created attachment 350991 [details]
patch
Created attachment 350992 [details]
patch
Created attachment 351017 [details]
patch
Attachment 351017 [details] did not pass style-queue:
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/node.py:194: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc9/libyasm-stdint.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/dj/libyasm-stdint.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/work_unit.py:3: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/work_unit.py:33: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/work_unit.py:58: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/work_unit.py:60: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/work_unit.py:64: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:3: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:33: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:186: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:520: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:522: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:524: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:594: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:597: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:622: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:634: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:655: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:657: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:696: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/cparse.py:698: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc10/libyasm-stdint.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/lexer.py:166: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/dj/config.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/genpyx.py:136: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:42: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:87: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:145: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:229: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:572: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:703: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:723: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:809: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:817: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:818: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:913: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:998: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/ir.py:1017: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/tests/gen-fma-test.py:33: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/tests/gen-fma-test.py:40: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/tests/gen-fma-test.py:55: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/tests/gen-fma-test.py:58: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/tests/gen-fma-test.py:60: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/tests/test_expr.py:9: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc9/vc98_swap.py:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc9/vc98_swap.py:50: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc9/readme.vc9.txt:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc10/config.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc10/readme.vc10.txt:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/python-yasm/pyxelator/wrap_yasm.py:3: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/Mkfiles/vc9/config.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:6996: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:7008: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:7024: trailing whitespace [pep8/W291] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8063: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8064: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8065: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8066: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8068: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8069: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8070: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8071: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8073: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8074: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8075: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8076: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8078: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8079: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8080: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8081: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8082: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8084: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8085: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8086: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8087: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8089: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8090: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8091: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8092: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8094: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8095: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8096: indentation contains tabs [pep8/W191] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/gen_x86_insn.py:8097: indentation contains tabs [pep8/W191] [5]
Total errors found: 910 in 1523 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 351051 [details]
Removing yasm ChangeLog and some unneeded files
Comment on attachment 351051 [details]
Removing yasm ChangeLog and some unneeded files
Issue with tabs prevent commit queue to land the patch
Created attachment 351105 [details]
Trying to fix allow tabs issue
Reverted r236620 for reason: broke internal Mac and iOS builds Committed r236626: <https://trac.webkit.org/changeset/236626> The patch still had tabs, it seems that allow-tabs property was used in the patch (therefore style-queue passed). However, that did not work well while committing. It might be that something is broken in handling 'allow-tabs' property, similar to https://bugs.webkit.org/show_bug.cgi?id=186624 More details about this commit-queue failure in: https://bugs.webkit.org/show_bug.cgi?id=186624 Correction: More details about this commit-queue failure in: https://bugs.webkit.org/show_bug.cgi?id=190102 Also, as per https://bugs.webkit.org/show_bug.cgi?id=186624, it seems that svn-apply doesn't properly handle 'allow-tabs' property, so it might be best to manually land patches with 'allow-tabs' property. Relanded most of the patch in https://trac.webkit.org/changeset/236642 "Add yasm source code and build the yasm executable as it is needed for libvpx compilati" says the commit message. |