Commit-queue tried to land the patch(351105) again, after it successfully landed the patch in https://webkit-queues.webkit.org/patch/351105/commit-queue Patch was for Bug: https://bugs.webkit.org/show_bug.cgi?id=190025
I think there were two issues here. One was patch having tabs instead of spaces (not sure why style queue did not catch it). Another was an error while setting appropriate bugzilla flags ('cq', 'r' flags). Not sure if the second error was due to first issue (tabs vs space). Therefore EWS considered the landing step as a failure, and it retried the patch after some time (on bot webkit-cq-01), and of-course the next attempt failed as the patch failed to apply (as it was already landed).
Logs: 2018-09-28 12:44:43,767 - Running: webkit-patch --status-host=webkit-queues.webkit.org --bot-id=webkit-cq-03 land-attachment --force-clean --non-interactive --parent-command=commit-queue 351051 --port=mac 2018-09-28 13:46:18,965 - Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 351051, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=351051&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=190025&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 351051 from bug 190025. Fetching: https://bugs.webkit.org/attachment.cgi?id=351051 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/translate.c A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/util.h A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/version A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86cpu.c A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86insn_gas.c A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86insn_gas.gperf A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86insn_nasm.c A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86insn_nasm.gperf A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86insns.c A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86regtmod.c A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/yasm.1 A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/yasm_arch.7 A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/yasm_dbgfmts.7 A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/yasm_objfmts.7 A Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/yasm_parsers.7 M Source/ThirdParty/libwebrtc/ChangeLog M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/frontends/yasm/yasm.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/gas-token.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/x86arch.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/arch/x86/x86id.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/objfmts/elf/elf-x86-x32.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/modules/preprocs/nasm/nasm-pp.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/nasm-token.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/actions.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/basics.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/bootstrap/scanner.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/code.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/dfa.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/dfa.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/examples/basemmap.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/examples/rexx/rexx.l trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/globals.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/ins.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/main.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/mbo_getopt.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/mbo_getopt.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/parse.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/parser.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/parser.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/re.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/scanner.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/scanner.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/substr.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/substr.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/tools/re2c/token.h trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86cpu.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86insn_gas.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86insn_nasm.c trunk/Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0/x86regtmod.c Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. W: 7a3922b5348bae69a663fe5f4efd3f58bda51c80 and refs/remotes/origin/master differ, using rebase: :040000 040000 c650bad82560ae5a6598c5733fd6fd5528875463 b68aab6a704f19fb97974134fed1e41a14388398 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 9367c18034c..4d389cd4f30 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 236605 = 9367c18034ce32ce20869a60a263117a737deb73 r236606 = 4d389cd4f30e9601087035d3b3e60b5552ca2803 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/9384930 Traceback (most recent call last): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 103, in run if not self._delegate.process_work_item(work_item): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/queues.py", line 377, in process_work_item validator.reject_patch_from_commit_queue(patch.id(), self._error_message_for_bug(task, patch, e)) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/config/committervalidator.py", line 85, in reject_patch_from_commit_queue comment_text) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 817, in set_flag_on_attachment self.browser.select_form(nr=1) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 499, in select_form global_form = self._factory.global_form File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 544, in __getattr__ self.forms() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 557, in forms self._forms_factory.forms()) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 237, in forms _urlunparse=_rfc3986.urlunsplit, File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 844, in ParseResponseEx _urlunparse=_urlunparse, File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 979, in _ParseFileEx data = file.read(CHUNK) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_response.py", line 195, in read data = self.wrapped.read(to_read) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 384, in read data = self._sock.recv(left) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 588, in read return self._read_chunked(amt) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 648, in _read_chunked value.append(self._safe_read(amt)) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 705, in _safe_read raise IncompleteRead(''.join(s), amt) IncompleteRead: IncompleteRead(0 bytes read, 1024 more expected) 2018-09-28 13:55:20,311 - Exception while preparing queue Sleeping until 2018-09-28 13:57:20 (120 seconds).
Also the large size of the patch (9.5mb) might have increased the chances of network error while communicating with bugzilla.
EWS has been re-implemented from scratch. New commit-queue does not run 'git svn dcommit' command multiple times. Please file new bug if any issue is noticed.