RESOLVED FIXED 189976
Add VP8 support to WebRTC
https://bugs.webkit.org/show_bug.cgi?id=189976
Summary Add VP8 support to WebRTC
youenn fablet
Reported 2018-09-25 15:30:20 PDT
Add libvpx support
Attachments
patch (9.03 MB, patch)
2018-09-25 15:40 PDT, youenn fablet
no flags
Patch (348.27 KB, patch)
2018-09-25 20:46 PDT, youenn fablet
no flags
Patch (352.90 KB, patch)
2018-09-26 12:51 PDT, youenn fablet
no flags
Patch (354.55 KB, patch)
2018-09-26 13:52 PDT, youenn fablet
no flags
Patch for landing (357.54 KB, patch)
2018-09-27 09:33 PDT, youenn fablet
no flags
Rebased patch (171.09 KB, patch)
2018-09-27 21:25 PDT, youenn fablet
no flags
Rebasing (324.48 KB, patch)
2018-09-29 11:19 PDT, youenn fablet
no flags
Fixing iOS (299.05 KB, patch)
2018-09-29 11:45 PDT, youenn fablet
no flags
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.86 MB, application/zip)
2018-09-29 13:06 PDT, EWS Watchlist
no flags
Fixing iOS (299.01 KB, patch)
2018-09-29 13:47 PDT, youenn fablet
no flags
Patch for landing (329.26 KB, patch)
2018-10-03 18:12 PDT, youenn fablet
no flags
youenn fablet
Comment 1 2018-09-25 15:40:38 PDT
youenn fablet
Comment 2 2018-09-25 20:46:08 PDT
EWS Watchlist
Comment 3 2018-09-25 20:50:28 PDT
Attachment 350843 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 4 2018-09-26 12:51:50 PDT
EWS Watchlist
Comment 5 2018-09-26 12:54:24 PDT
Attachment 350885 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 6 2018-09-26 13:52:43 PDT
EWS Watchlist
Comment 7 2018-09-26 13:57:03 PDT
Attachment 350898 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 8 2018-09-27 08:13:05 PDT
Comment on attachment 350898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350898&action=review > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vpx_config.h:66 > -#define CONFIG_VP9 1 > +#define CONFIG_VP9 0 No more VP9? > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:-14743 > - 41F411BF1EF8DBA500343C26 /* vp8_noop.cc in Sources */, We could remove this file.
youenn fablet
Comment 9 2018-09-27 08:33:13 PDT
(In reply to Alex Christensen from comment #8) > Comment on attachment 350898 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350898&action=review > > > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vpx_config.h:66 > > -#define CONFIG_VP9 1 > > +#define CONFIG_VP9 0 > > No more VP9? This vpx_config.h is the default one and we need to update it for WebKit. > > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:-14743 > > - 41F411BF1EF8DBA500343C26 /* vp8_noop.cc in Sources */, > > We could remove this file. Right.
Eric Carlson
Comment 10 2018-09-27 09:10:43 PDT
Comment on attachment 350898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350898&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:130 > + bool m_isSupportingVP8 { false }; Nit: I think "m_supportsVP8" would be better.
youenn fablet
Comment 11 2018-09-27 09:33:27 PDT
Created attachment 350970 [details] Patch for landing
EWS Watchlist
Comment 12 2018-09-27 09:36:50 PDT
Attachment 350970 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 13 2018-09-27 10:16:55 PDT
Comment on attachment 350970 [details] Patch for landing Clearing flags on attachment: 350970 Committed r236557: <https://trac.webkit.org/changeset/236557>
WebKit Commit Bot
Comment 14 2018-09-27 10:16:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-09-27 10:17:26 PDT
Konstantin Tokarev
Comment 16 2018-09-27 10:21:04 PDT
You've (I guess accidentally) committed a bunch of object files with this patch ( Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/common/x86/copy_sse2.asm.o etc)
youenn fablet
Comment 17 2018-09-27 10:23:03 PDT
(In reply to Konstantin Tokarev from comment #16) > You've (I guess accidentally) committed a bunch of object files with this > patch ( > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/ > common/x86/copy_sse2.asm.o etc) These asm object files will be generated by yasm dynamically as part of https://bugs.webkit.org/show_bug.cgi?id=190025
Ryan Haddad
Comment 18 2018-09-27 11:30:55 PDT
Rolled out this change in https://trac.webkit.org/r236561 because it broke internal builds.
youenn fablet
Comment 19 2018-09-27 21:25:07 PDT
Created attachment 351049 [details] Rebased patch
youenn fablet
Comment 20 2018-09-29 11:19:42 PDT
Created attachment 351189 [details] Rebasing
EWS Watchlist
Comment 21 2018-09-29 11:22:31 PDT
Attachment 351189 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 22 2018-09-29 11:45:53 PDT
Created attachment 351191 [details] Fixing iOS
EWS Watchlist
Comment 23 2018-09-29 11:47:54 PDT
Attachment 351191 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 24 2018-09-29 13:06:35 PDT
Comment on attachment 351191 [details] Fixing iOS Attachment 351191 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9395851 New failing tests: media/range-extract-contents-crash.html
EWS Watchlist
Comment 25 2018-09-29 13:06:37 PDT
Created attachment 351194 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
youenn fablet
Comment 26 2018-09-29 13:47:19 PDT
Created attachment 351195 [details] Fixing iOS
EWS Watchlist
Comment 27 2018-09-29 13:49:19 PDT
Attachment 351195 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 28 2018-10-03 18:12:15 PDT
Created attachment 351569 [details] Patch for landing
EWS Watchlist
Comment 29 2018-10-03 18:14:00 PDT
Attachment 351569 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 30 2018-10-03 18:53:37 PDT
Comment on attachment 351569 [details] Patch for landing Clearing flags on attachment: 351569 Committed r236821: <https://trac.webkit.org/changeset/236821>
WebKit Commit Bot
Comment 31 2018-10-03 18:53:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.