Bug 189976 – Add VP8 support to WebRTC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add libvpx support

[youenn fablet]

Created attachment 350805 [details]
patch

[youenn fablet]

Created attachment 350843 [details]
Patch

[EWS Watchlist]

Attachment 350843 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 350885 [details]
Patch

[EWS Watchlist]

Attachment 350885 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 350898 [details]
Patch

[EWS Watchlist]

Attachment 350898 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 350898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350898&action=review

> Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vpx_config.h:66
> -#define CONFIG_VP9 1
> +#define CONFIG_VP9 0

No more VP9?

> Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:-14743
> -				41F411BF1EF8DBA500343C26 /* vp8_noop.cc in Sources */,

We could remove this file.

[youenn fablet]

(In reply to Alex Christensen from comment #8)
> Comment on attachment 350898 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350898&action=review
> 
> > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vpx_config.h:66
> > -#define CONFIG_VP9 1
> > +#define CONFIG_VP9 0
>
> No more VP9?

This vpx_config.h is the default one and we need to update it for WebKit.
 
> > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:-14743
> > -				41F411BF1EF8DBA500343C26 /* vp8_noop.cc in Sources */,
> 
> We could remove this file.

Right.

[Eric Carlson]

Comment on attachment 350898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350898&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:130
> +    bool m_isSupportingVP8 { false };

Nit: I think "m_supportsVP8" would be better.

[youenn fablet]

Created attachment 350970 [details]
Patch for landing

[EWS Watchlist]

Attachment 350970 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 350970 [details]
Patch for landing

Clearing flags on attachment: 350970

Committed r236557: <https://trac.webkit.org/changeset/236557>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44834363>

[Konstantin Tokarev]

You've (I guess accidentally) committed a bunch of object files with this patch (
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/common/x86/copy_sse2.asm.o etc)

[youenn fablet]

(In reply to Konstantin Tokarev from comment #16)
> You've (I guess accidentally) committed a bunch of object files with this
> patch (
> Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/
> common/x86/copy_sse2.asm.o etc)

These asm object files will be generated by yasm dynamically as part of https://bugs.webkit.org/show_bug.cgi?id=190025

[Ryan Haddad]

Rolled out this change in https://trac.webkit.org/r236561 because it broke internal builds.

[youenn fablet]

Created attachment 351049 [details]
Rebased patch

[youenn fablet]

Created attachment 351189 [details]
Rebasing

[EWS Watchlist]

Attachment 351189 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 351191 [details]
Fixing iOS

[EWS Watchlist]

Attachment 351191 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 351191 [details]
Fixing iOS

Attachment 351191 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9395851

New failing tests:
media/range-extract-contents-crash.html

[EWS Watchlist]

Created attachment 351194 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Created attachment 351195 [details]
Fixing iOS

[EWS Watchlist]

Attachment 351195 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 351569 [details]
Patch for landing

[EWS Watchlist]

Attachment 351569 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:112:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 351569 [details]
Patch for landing

Clearing flags on attachment: 351569

Committed r236821: <https://trac.webkit.org/changeset/236821>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.