Bug 190023
| Summary: | Considering making Options::useSeparatedWXHeap() always false if ENABLE(FAST_JIT_PERMISSIONS). | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | fpizlo, keith_miller, msaboff, rmorisset, saam, sam, tzagallo |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 190022 | ||
| Bug Blocks: | |||
Mark Lam
In https://bugs.webkit.org/show_bug.cgi?id=190022, we disable Options::useSeparatedWXHeap() if ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E). However, I think we can disable if
Options::useSeparatedWXHeap() if we have ENABLE(FAST_JIT_PERMISSIONS). It doesn't have to be CPU(ARM64E). Consider making this so.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Lam
See https://bugs.webkit.org/show_bug.cgi?id=190022#c3:
Also consider introducing a new ENABLE macro specifically for SeparatedWXHeap, an ENABLE_SEPARATED_WXHEAP for the purpose of making the code more readable.