Bug 190022

Summary: Options::useSeparatedWXHeap() should always be false when ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E).
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, keith_miller, msaboff, rmorisset, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190023    
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2018-09-26 18:12:25 PDT
<rdar://problem/44800928>
Attachments
proposed patch. (5.73 KB, patch)
2018-09-26 18:24 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-09-26 18:24:40 PDT
Created attachment 350933 [details] proposed patch.
Mark Lam
Comment 2 2018-09-26 21:37:09 PDT
Thanks for the review. Landed in r236538: <http://trac.webkit.org/r236538>.
Sam Weinig
Comment 3 2018-09-27 10:14:27 PDT
Comment on attachment 350933 [details] proposed patch. I think this might be a little more clear if you introduced a new ENABLE macro specifically for SeparatedWXHeap, an ENABLE_ SEPARATED_WXHEAP.
Note You need to log in before you can comment on or make changes to this bug.