Bug 189986

Summary: [WHLSL] Pointers should have automatically-generated equality checks
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, fpizlo, rmorisset, tdenney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189202, 189210    
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2018-09-25 21:39:51 PDT
[WHLSL] Pointers should have automatically-generated equality checks
Attachments
Patch (83.67 KB, patch)
2018-09-25 21:46 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (89.38 KB, patch)
2018-09-25 22:11 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-09-25 21:46:08 PDT
Created attachment 350845 [details] Patch
EWS Watchlist
Comment 2 2018-09-25 21:48:31 PDT
Attachment 350845 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:787: developmentRegion is not English. [xcodeproj/settings] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 3 2018-09-25 22:11:33 PDT
Created attachment 350847 [details] Patch
EWS Watchlist
Comment 4 2018-09-25 22:14:29 PDT
Attachment 350847 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:787: developmentRegion is not English. [xcodeproj/settings] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2018-09-28 17:48:41 PDT
Comment on attachment 350847 [details] Patch Clearing flags on attachment: 350847 Committed r236628: <https://trac.webkit.org/changeset/236628>
WebKit Commit Bot
Comment 6 2018-09-28 17:48:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-28 17:49:21 PDT
<rdar://problem/44880171>
Myles C. Maxfield
Comment 8 2018-10-13 14:23:03 PDT
Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/22
Myles C. Maxfield
Comment 9 2018-10-13 14:51:18 PDT
https://github.com/gpuweb/WHLSL/issues/22
Note You need to log in before you can comment on or make changes to this bug.