Bug 189883

Summary: Native functions which accept pointers need to do null checks
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, fpizlo, jonlee, rmorisset, tdenney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189202    
Attachments:
Description Flags
Patch dino: review+

Myles C. Maxfield
Reported 2018-09-22 03:28:24 PDT
WHLSL functions automatically do null checks, but the native functions don't.
Attachments
Patch (26.86 KB, patch)
2018-09-22 15:56 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-09-22 15:56:35 PDT
Created attachment 350536 [details] Patch
Myles C. Maxfield
Comment 2 2018-09-22 16:34:57 PDT
Committed r236388: <https://trac.webkit.org/changeset/236388>
Radar WebKit Bug Importer
Comment 3 2018-09-22 16:35:19 PDT
<rdar://problem/44708648>
Myles C. Maxfield
Comment 4 2018-10-13 14:23:16 PDT
Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/29
Myles C. Maxfield
Comment 5 2018-10-13 14:52:50 PDT
https://github.com/gpuweb/WHLSL/issues/29
Note You need to log in before you can comment on or make changes to this bug.