Bug 189867 – Add PointerEvent, plus feature flag, plus Web Platform Tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Dean Jackson]

Add PointerEvent, plus feature flag, plus Web Platform Tests

[Radar WebKit Bug Importer]

<rdar://problem/44697384>

[Dean Jackson]

Created attachment 350457 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 350457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350457&action=review

Please also add to features.json

> Source/WebCore/dom/PointerEvent.cpp:35
> +PointerEvent::PointerEvent()
> +{
> +}

Remove or use = default

> Source/WebCore/dom/PointerEvent.cpp:48
> +    , m_pointerId(WTFMove(initializer.pointerId))
> +    , m_width(WTFMove(initializer.width))
> +    , m_height(WTFMove(initializer.height))
> +    , m_pressure(WTFMove(initializer.pressure))
> +    , m_tangentialPressure(WTFMove(initializer.tangentialPressure))
> +    , m_tiltX(WTFMove(initializer.tiltX))
> +    , m_tiltY(WTFMove(initializer.tiltY))
> +    , m_twist(WTFMove(initializer.twist))
> +    , m_pointerType(WTFMove(initializer.pointerType))
> +    , m_isPrimary(WTFMove(initializer.isPrimary))

No need to WTFMove POD

> Source/WebCore/page/RuntimeEnabledFeatures.h:340
> +    bool m_areWebAnimationsEnabled { true };
> +    bool m_isWebAnimationsCSSIntegrationEnabled { false };
> +    bool m_isImageBitmapOffscreenCanvasEnabled { true };
> +    bool m_isCacheAPIEnabled { false };
> +    bool m_isFetchAPIEnabled { true };
> +    bool m_isWebSocketEnabled { true };
> +    bool m_fetchAPIKeepAliveEnabled { false };
> +    bool m_inspectorAdditionsEnabled { false };
> +    bool m_webVREnabled { false };
> +    bool m_accessibilityObjectModelEnabled { false };
> +    bool m_ariaReflectionEnabled { true };
> +    bool m_resourceLoadStatisticsDebugMode { false };
> +    bool m_isRestrictedHTTPResponseAccess { true };
> +    bool m_crossOriginResourcePolicyEnabled { true };
> +    bool m_isWebGLCompressedTextureASTCSupportEnabled { false };
> +    bool m_promptForStorageAccessAPIEnabled { false };
> +    bool m_isServerTimingEnabled { false };
> +    bool m_experimentalPlugInSandboxProfilesEnabled { false };
> +    bool m_disabledAdaptationsMetaTagEnabled { false };
> +    bool m_attrStyleEnabled { false };
> +    bool m_webAPIStatisticsEnabled { false };
> +    bool m_CSSCustomPropertiesAndValuesEnabled { false };
> +    bool m_pointerEventsEnabled { false };

Please sort.

[Dean Jackson]

Committed r236378: <https://trac.webkit.org/changeset/236378>

[David Tapuska]

Will https://bugs.webkit.org/show_bug.cgi?id=133112 be fixed too?

[Dean Jackson]

(In reply to David Tapuska from comment #5)
> Will https://bugs.webkit.org/show_bug.cgi?id=133112 be fixed too?

Yes

[David Tapuska]

Whoot! Great work.. looking forward to testing for interop.