Bug 189688

Summary: Update flakiness dashboard configuration for iOS 12 queues
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, don.olmstead, fujii.hironori, lforschler, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 189683    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Ryan Haddad
Reported 2018-09-17 21:34:46 PDT
Update flakiness dashboard configuration for iOS 12 queues
Attachments
Patch (2.07 KB, patch)
2018-09-21 21:04 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2018-09-24 09:16 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-09-21 21:04:52 PDT
Created attachment 350488 [details] Patch
Ryan Haddad
Comment 2 2018-09-21 21:12:01 PDT
CC'ing some Sony folks as an FYI since this incidentally adds WinCairo support to the flakiness dashboard.
Ross Kirsling
Comment 3 2018-09-21 23:36:32 PDT
I think we might be missing some other pieces too though: https://bugs.webkit.org/show_bug.cgi?id=188345 Fujii-san, is your patch on that ticket ready for review?
Fujii Hironori
Comment 4 2018-09-23 01:21:55 PDT
I hesitate to land the patch because WinCairo Debug buildbos are broken all the time. But, I didn’t know the script generate_builders_json.py. I should add WinCairo Realse and Debug bots.
Ryan Haddad
Comment 5 2018-09-24 09:11:45 PDT
(In reply to Fujii Hironori from comment #4) > I hesitate to land the patch because WinCairo Debug buildbos are broken all > the time. But, I didn’t know the script generate_builders_json.py. I should > add WinCairo Realse and Debug bots. I need to get iOS 12 support up ASAP, so I'm just going to edit my patch to remove WPE for now. You can add it with your change when you are ready.
Ryan Haddad
Comment 6 2018-09-24 09:16:51 PDT
Created attachment 350644 [details] Patch
Alexey Proskuryakov
Comment 7 2018-09-24 09:18:45 PDT
Comment on attachment 350644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350644&action=review > Tools/TestResultServer/static-dashboards/builders.jsonp:26 > - "WPE Linux 64-bit Release (Tests)", > - "WPE Linux 64-bit Debug (Tests)" > + "WPE Linux 64-bit Debug (Tests)", > + "WPE Linux 64-bit Release (Tests)" What does this change?
Ryan Haddad
Comment 8 2018-09-24 09:21:24 PDT
(In reply to Ryan Haddad from comment #5) > (In reply to Fujii Hironori from comment #4) > > I hesitate to land the patch because WinCairo Debug buildbos are broken all > > the time. But, I didn’t know the script generate_builders_json.py. I should > > add WinCairo Realse and Debug bots. > I need to get iOS 12 support up ASAP, so I'm just going to edit my patch to > remove WPE for now. You can add it with your change when you are ready. s/WPE/WinCairo
Ryan Haddad
Comment 9 2018-09-24 09:21:56 PDT
(In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 350644 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350644&action=review > > > Tools/TestResultServer/static-dashboards/builders.jsonp:26 > > - "WPE Linux 64-bit Release (Tests)", > > - "WPE Linux 64-bit Debug (Tests)" > > + "WPE Linux 64-bit Debug (Tests)", > > + "WPE Linux 64-bit Release (Tests)" > > What does this change? The generate_builders_json.py script alphabetized these automatically when I ran it.
Alexey Proskuryakov
Comment 10 2018-09-24 09:29:22 PDT
And added trailing whitespace, it seems!
WebKit Commit Bot
Comment 11 2018-09-24 10:13:15 PDT
Comment on attachment 350644 [details] Patch Clearing flags on attachment: 350644 Committed r236406: <https://trac.webkit.org/changeset/236406>
WebKit Commit Bot
Comment 12 2018-09-24 10:13:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-09-24 10:14:23 PDT
<rdar://problem/44730039>
Aakash Jain
Comment 14 2018-09-24 18:46:06 PDT
Deployed on webkit-test-results, it's live now.
Note You need to log in before you can comment on or make changes to this bug.