Bug 189683

Summary: Bring up queues for iOS 12
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, commit-queue, jbedard, jlewis3, lforschler, realdawei, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189688, 189839    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch none

Ryan Haddad
Reported 2018-09-17 16:17:41 PDT
Bring up queues for iOS 12
Attachments
Patch (141.55 KB, patch)
2018-09-17 21:27 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (141.48 KB, patch)
2018-09-17 22:06 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (154.52 KB, patch)
2018-09-18 09:04 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.97 KB, patch)
2018-09-21 09:36 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2018-09-21 10:23 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-09-17 21:27:28 PDT
Created attachment 349997 [details] Patch
Ryan Haddad
Comment 2 2018-09-17 22:06:58 PDT
Created attachment 350001 [details] Patch
Alexey Proskuryakov
Comment 3 2018-09-17 23:56:02 PDT
We probably need flakiness dashboard changes as well. Also, IIRC there was a unit test for config.json in webkitpy (which should have been run by EWS, but wasn't).
Jonathan Bedard
Comment 4 2018-09-18 08:18:14 PDT
I wanted to call out the fact that Ryan changed the default iOS version in webkitpy in r233832, so that is not needed in this change.
Ryan Haddad
Comment 5 2018-09-18 09:04:52 PDT
Created attachment 350023 [details] Patch
Ryan Haddad
Comment 6 2018-09-18 09:06:08 PDT
(In reply to Alexey Proskuryakov from comment #3) > We probably need flakiness dashboard changes as well. Also, IIRC there was a > unit test for config.json in webkitpy (which should have been run by EWS, > but wasn't). https://bugs.webkit.org/show_bug.cgi?id=189688 tracks the flakiness dashboard changes. The script that generates the config requires the builders to be in place first. Thanks for the reminder about the unit tests. New patch addresses these.
WebKit Commit Bot
Comment 7 2018-09-20 16:50:17 PDT
Comment on attachment 350023 [details] Patch Clearing flags on attachment: 350023 Committed r236294: <https://trac.webkit.org/changeset/236294>
WebKit Commit Bot
Comment 8 2018-09-20 16:50:18 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-09-20 16:51:40 PDT
<rdar://problem/44661252>
Jonathan Bedard
Comment 10 2018-09-21 09:36:51 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 11 2018-09-21 09:36:52 PDT
Created attachment 350373 [details] Patch for landing
WebKit Commit Bot
Comment 12 2018-09-21 10:13:44 PDT
Comment on attachment 350373 [details] Patch for landing Clearing flags on attachment: 350373 Committed r236331: <https://trac.webkit.org/changeset/236331>
WebKit Commit Bot
Comment 13 2018-09-21 10:13:46 PDT
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 14 2018-09-21 10:23:04 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 15 2018-09-21 10:23:05 PDT
Created attachment 350376 [details] Patch
Jonathan Bedard
Comment 16 2018-09-21 10:24:14 PDT
(In reply to Jonathan Bedard from comment #15) > Created attachment 350376 [details] > Patch Running this through EWS to make sure it doesn't break anything else, verified that this fixes iOS 12 device and simulator builds.
Jonathan Bedard
Comment 17 2018-09-21 11:07:31 PDT
Comment on attachment 350376 [details] Patch Builds for iOS and Mac passed, those were what might have been broken by this change. Landing to fix our iOS 12 builders.
WebKit Commit Bot
Comment 18 2018-09-21 11:33:27 PDT
Comment on attachment 350376 [details] Patch Clearing flags on attachment: 350376 Committed r236337: <https://trac.webkit.org/changeset/236337>
WebKit Commit Bot
Comment 19 2018-09-21 11:33:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.