Bug 189535

Summary: [WHLSL] The standard library should be fully tested
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: New BugsAssignee: Thomas Denney <tdenney>
Status: RESOLVED MOVED    
Severity: Normal CC: dino, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
WIP none

Thomas Denney
Reported 2018-09-11 18:54:09 PDT
[WHLSL] The standard library should be fully tested
Attachments
WIP (1.37 KB, patch)
2018-09-11 18:54 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-09-11 18:54:46 PDT
Created attachment 349500 [details] WIP
Thomas Denney
Comment 2 2018-09-11 19:00:05 PDT
We cannot remove the preparation stage that type checks the standard library in full (which makes running tests *much* faster) without ensuring that every function in the standard library is tested to ensure that each standard library function actually gets type checked.
Myles C. Maxfield
Comment 3 2018-09-21 18:16:23 PDT
There are a couple functions that I'm not very confident that their behavior matches HLSL: firstbithigh() firstbitlow() countbits() reversebits() all the texturing functions Also, these functions are implemented in a suboptimal way: log2() log10() exp2() fmod() isordered() Also: fma() and mad() are implemented identically, and I'm not sure if this is right.
Thomas Denney
Comment 4 2018-09-21 18:57:18 PDT
(In reply to Myles C. Maxfield from comment #3) > There are a couple functions that I'm not very confident that their behavior > matches HLSL: > > firstbithigh() > firstbitlow() > countbits() > reversebits() > all the texturing functions > > Also, these functions are implemented in a suboptimal way: > > log2() > log10() > exp2() > fmod() > isordered() > > Also: fma() and mad() are implemented identically, and I'm not sure if this > is right. Likewise I’m pretty sure that isnormal isn’t implement correctly (it currently returns isNaN).
Myles C. Maxfield
Comment 5 2018-10-13 14:30:56 PDT
Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/36
Myles C. Maxfield
Comment 6 2018-10-13 14:54:37 PDT
https://github.com/gpuweb/WHLSL/issues/36
Note You need to log in before you can comment on or make changes to this bug.