Summary: | Modify more tests to use document.scrollingElement to access viewport scroll properties | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Component: | Media | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, rniwa, simon.fraser, tonikitoo, tsavell, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://github.com/web-platform-tests/wpt/pull/12944 | ||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2018-09-10 23:08:41 PDT
Created attachment 349383 [details]
Patch
Comment on attachment 349383 [details] Patch Attachment 349383 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9169925 New failing tests: fast/scrolling/rtl-point-in-iframe.html fast/multicol/body-stuck-with-dirty-bit-with-columns.html Created attachment 349385 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 349383 [details] Patch Attachment 349383 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9169935 New failing tests: fast/scrolling/rtl-point-in-iframe.html fast/multicol/body-stuck-with-dirty-bit-with-columns.html Created attachment 349386 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 349387 [details]
Patch
Created attachment 349388 [details]
Patch
Comment on attachment 349388 [details]
Patch
r=me
Ideally, we should prevent new code to use document.body on tests. is there a way?
(In reply to Antonio Gomes from comment #8) > Comment on attachment 349388 [details] > Patch > > r=me > > Ideally, we should prevent new code to use document.body on tests. is there > a way? Hopefully, now that the standard behavior is enabled for tests people will notice that document.body does not work. Comment on attachment 349388 [details] Patch Clearing flags on attachment: 349388 Committed r235893: <https://trac.webkit.org/changeset/235893> All reviewed patches have been landed. Closing bug. |