Summary: | [iOS] Unable to change the value of select elements while preserving focus state | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | Forms | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, cdumez, commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2018-09-10 11:30:06 PDT
Created attachment 349332 [details]
Patch
Comment on attachment 349332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349332&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:458 > + // However, unlike active focus state, it may be safely reset to 0. Probably need to define "safely" here. "Without impact to existing API contracts?" Comment on attachment 349332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349332&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:458 >> + // However, unlike active focus state, it may be safely reset to 0. > > Probably need to define "safely" here. "Without impact to existing API contracts?" That's right — it's part "without impact to existing behavior of -_retainActiveFocusedState", and also part "able to be reset to 0 at any time" (with future calls to decrement the counter being noops). I'll clarify this in the comment. Created attachment 349354 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 349354 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 349354 [details]: imported/w3c/web-platform-tests/xhr/access-control-and-redirects.htm bug 189489 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 349354 [details] Patch for landing Clearing flags on attachment: 349354 Committed r235878: <https://trac.webkit.org/changeset/235878> All reviewed patches have been landed. Closing bug. |