Bug 189417

Summary: [ews-build] API tests should output result summary in json
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187330
https://bugs.webkit.org/show_bug.cgi?id=187331
https://bugs.webkit.org/show_bug.cgi?id=202854
Attachments:
Description Flags
Proposed patch
lforschler: review+
Patch for landing none

Aakash Jain
Reported 2018-09-07 10:50:01 PDT
API tests should output result in json. This would be useful in easily parsing the errors.
Attachments
Proposed patch (5.75 KB, patch)
2018-09-07 10:55 PDT, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
Patch for landing (5.76 KB, patch)
2018-09-07 11:12 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-09-07 10:55:45 PDT
Created attachment 349159 [details] Proposed patch This is very similar to https://bugs.webkit.org/show_bug.cgi?id=187330 and https://bugs.webkit.org/show_bug.cgi?id=187331
Aakash Jain
Comment 2 2018-09-07 10:57:48 PDT
Tested in http://ews-build.webkit-uat.org/#/builders/19/builds/18
Lucas Forschler
Comment 3 2018-09-07 11:04:23 PDT
Comment on attachment 349159 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=349159&action=review > Tools/ChangeLog:3 > + [ews-build] API tests should output result in json API tests should output result SUMMARY in json > Tools/BuildSlaveSupport/ews-build/steps.py:482 > + jsonFileName = 'api_test_results.json' jsonFileName = 'api_test_results_summary.json' > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:931 > + self.jsonFileName = 'api_test_results.json' api_test_results_summary.json
Aakash Jain
Comment 4 2018-09-07 11:12:08 PDT
Created attachment 349165 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-09-07 11:49:31 PDT
Comment on attachment 349165 [details] Patch for landing Clearing flags on attachment: 349165 Committed r235789: <https://trac.webkit.org/changeset/235789>
WebKit Commit Bot
Comment 6 2018-09-07 11:49:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-07 11:50:42 PDT
<rdar://problem/44232647>
Note You need to log in before you can comment on or make changes to this bug.