Summary: | [WHLSL] Call arguments should be copied as soon as they are evaluated | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thomas Denney <tdenney> | ||||
Component: | WebGPU | Assignee: | Thomas Denney <tdenney> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, mmaxfield, tdenney, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 176199, 189202, 189326 | ||||||
Attachments: |
|
Description
Thomas Denney
2018-09-06 10:52:08 PDT
Created attachment 349045 [details]
Patch
Comment on attachment 349045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review > Tools/WebGPUShadingLanguageRI/Evaluator.js:325 > + let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node)); I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code? Comment on attachment 349045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review >> Tools/WebGPUShadingLanguageRI/Evaluator.js:325 >> + let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node)); > > I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code? Got it. Looks good. Comment on attachment 349045 [details] Patch Clearing flags on attachment: 349045 Committed r235753: <https://trac.webkit.org/changeset/235753> All reviewed patches have been landed. Closing bug. Migrated to https://github.com/gpuweb/WHLSL/issues/41 |