Bug 189175

Summary:

[WHLSL] Fix array indexing behavior

Product:

WebKit

Reporter:

Thomas Denney <tdenney>

Component:

WebGPU

Assignee:

Thomas Denney <tdenney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

189099

Bug Blocks:

176199

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Thomas Denney

Reported 2018-08-30 14:46:42 PDT

Currently WHLSL parses the declaration "int[2][3] array” as an array of length 3 of arrays of 2 integers; we need the reverse to match C.

Attachments
Patch (3.17 KB, patch) 2018-08-30 16:47 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
Patch (3.35 KB, patch) 2018-08-30 16:56 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
Patch (3.25 KB, patch) 2018-08-30 16:59 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Thomas Denney

Comment 1 2018-08-30 16:47:34 PDT

Created attachment 348568 [details] Patch

Myles C. Maxfield

Comment 2 2018-08-30 16:50:34 PDT

Comment on attachment 348568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348568&action=review > Tools/ChangeLog:7 > + > + Reviewed by NOBODY (OOPS!). > + Need some description > Tools/WebGPUShadingLanguageRI/Parse.js:266 > + // token is updated each iteration, so constructors must use the token associated with their iteration. > + const tokenCopy = token; can you fix this by saying "while (let token = ...)"?

Thomas Denney

Comment 3 2018-08-30 16:56:50 PDT

Created attachment 348570 [details] Patch

Thomas Denney

Comment 4 2018-08-30 16:59:12 PDT

Created attachment 348571 [details] Patch

WebKit Commit Bot

Comment 5 2018-08-30 17:39:16 PDT

Comment on attachment 348571 [details] Patch Clearing flags on attachment: 348571 Committed r235533: <https://trac.webkit.org/changeset/235533>

WebKit Commit Bot

Comment 6 2018-08-30 17:39:17 PDT

All reviewed patches have been landed. Closing bug.