Bug 189134

Summary:

[WHSL] Implement semantics

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGPU

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, fpizlo, jonlee, rmorisset, tdenney, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=189033

Bug Depends on:

Bug Blocks:

176199, 189202

Attachments:

Description	Flags
WIP	none
WIP	none
Patch	fpizlo: review+
Patch for committing	none
Patch for committing	none
Patch for committing	none

Myles C. Maxfield

Reported 2018-08-29 17:45:38 PDT

Implement semantics

Attachments
WIP (81.82 KB, patch) 2018-09-21 21:33 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (81.82 KB, patch) 2018-09-21 21:35 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (100.06 KB, patch) 2018-09-22 01:43 PDT, Myles C. Maxfield	fpizlo: review+	Details Formatted Diff Diff
Patch for committing (99.84 KB, patch) 2018-09-24 23:48 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (102.55 KB, patch) 2018-09-25 13:43 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (104.57 KB, patch) 2018-09-25 13:55 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-09-12 18:50:31 PDT

<rdar://problem/44402998>

Myles C. Maxfield

Comment 2 2018-09-21 21:33:46 PDT

Created attachment 350491 [details] WIP

Myles C. Maxfield

Comment 3 2018-09-21 21:35:17 PDT

Created attachment 350493 [details] WIP

Myles C. Maxfield

Comment 4 2018-09-22 01:27:45 PDT

*** Bug 189033 has been marked as a duplicate of this bug. ***

Myles C. Maxfield

Comment 5 2018-09-22 01:43:05 PDT

Created attachment 350505 [details] Patch

Myles C. Maxfield

Comment 6 2018-09-22 02:47:00 PDT

*** Bug 189387 has been marked as a duplicate of this bug. ***

Myles C. Maxfield

Comment 7 2018-09-22 14:30:25 PDT

Comment on attachment 350505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350505&action=review > Tools/WebGPUShadingLanguageRI/Parse.js:1230 > + return fail("Semantic is not 32-bit unsigned integer: " + index.text); Double space

Filip Pizlo

Comment 8 2018-09-24 15:41:31 PDT

Comment on attachment 350505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350505&action=review > Tools/WebGPUShadingLanguageRI/Field.js:2 > - * Copyright (C) 2017 Apple Inc. All rights reserved. > + * Copyright (C) 2018 Apple Inc. All rights reserved. 2017-2018 > Tools/WebGPUShadingLanguageRI/FuncParameter.js:2 > - * Copyright (C) 2017 Apple Inc. All rights reserved. > + * Copyright (C) 2018 Apple Inc. All rights reserved. 2017-2018

Myles C. Maxfield

Comment 9 2018-09-24 23:48:57 PDT

Created attachment 350740 [details] Patch for committing

Myles C. Maxfield

Comment 10 2018-09-25 13:43:12 PDT

Created attachment 350782 [details] Patch for committing

Myles C. Maxfield

Comment 11 2018-09-25 13:55:13 PDT

Created attachment 350788 [details] Patch for committing

Myles C. Maxfield

Comment 12 2018-09-25 14:21:49 PDT

Committed r236475: <https://trac.webkit.org/changeset/236475>

Myles C. Maxfield

Comment 13 2018-10-13 14:44:16 PDT

Migrated to https://github.com/gpuweb/WHLSL/issues/52

Note You need to log in before you can comment on or make changes to this bug.