Bug 189108

Summary: [WHSL] Need grammar to specify kernel group size
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189202    
Attachments:
Description Flags
Patch dino: review+

Description Myles C. Maxfield 2018-08-29 16:12:06 PDT 
https://github.com/Microsoft/DirectX-Graphics-Samples/blob/8f68bf07dfd134df3b90e83a63535d053bae9a8a/Libraries/D3D12RaytracingFallback/src/FallbackLayerUnitTests/DynamicIndexTest.hlsl

Compute shader entry points need to have something like the following before their declaration:
[numthreads( 8, 8, 1 )]
Comment 2 Radar WebKit Bug Importer 2018-09-12 18:51:02 PDT 
<rdar://problem/44403004>
Comment 3 Myles C. Maxfield 2018-09-22 14:05:55 PDT 
*** Bug 189384 has been marked as a duplicate of this bug. ***
Comment 4 Myles C. Maxfield 2018-09-22 15:17:26 PDT 
Created attachment 350534 [details]
Patch
Comment 5 Myles C. Maxfield 2018-09-22 16:49:42 PDT 
Committed r236390: <https://trac.webkit.org/changeset/236390>
Comment 6 Myles C. Maxfield 2018-10-13 14:58:53 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/66