Bug 188940

Summary: [WHLSL] Implement texture types
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189202, 189225, 189226    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
Can sample
none
Can sample
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
Cubemaps complete
none
Started gathering
none
Test gathering
none
Patch
none
Needs finishing touches
none
Needs tests for SampleCmpLevelZero
none
Patch dino: review+

Myles C. Maxfield
Reported 2018-08-24 19:19:59 PDT
[WHLSL] Implement texture types
Attachments
WIP (197.83 KB, patch)
2018-08-24 19:20 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (196.22 KB, patch)
2018-08-28 15:06 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (203.86 KB, patch)
2018-08-28 17:31 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (238.46 KB, patch)
2018-08-28 19:24 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (54.24 KB, patch)
2018-08-29 14:19 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (54.62 KB, patch)
2018-08-29 18:23 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (66.84 KB, patch)
2018-08-29 19:13 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (66.99 KB, patch)
2018-08-29 19:18 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (79.99 KB, patch)
2018-08-30 11:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (86.58 KB, patch)
2018-08-30 19:24 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (86.65 KB, patch)
2018-08-30 19:25 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (89.16 KB, patch)
2018-08-30 23:04 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (108.18 KB, patch)
2018-08-31 12:08 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (163.98 KB, patch)
2018-08-31 17:22 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Can sample (165.51 KB, patch)
2018-08-31 18:25 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Can sample (167.05 KB, patch)
2018-08-31 19:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (170.72 KB, patch)
2018-08-31 22:02 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (183.19 KB, patch)
2018-09-01 14:03 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (192.66 KB, patch)
2018-09-01 15:18 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (219.11 KB, patch)
2018-09-01 18:13 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (255.38 KB, patch)
2018-09-01 19:36 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (396.04 KB, patch)
2018-09-01 22:28 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (401.56 KB, patch)
2018-09-01 22:40 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (428.97 KB, patch)
2018-09-02 17:03 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (414.79 KB, patch)
2018-09-02 22:58 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Cubemaps complete (426.25 KB, patch)
2018-09-03 09:20 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Started gathering (434.52 KB, patch)
2018-09-03 15:23 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Test gathering (456.47 KB, patch)
2018-09-03 17:06 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (458.01 KB, patch)
2018-09-03 17:33 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Needs finishing touches (458.00 KB, patch)
2018-09-03 19:51 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Needs tests for SampleCmpLevelZero (459.30 KB, patch)
2018-09-03 19:56 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (488.01 KB, patch)
2018-09-03 21:39 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (31) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-08-24 19:20:21 PDT
Created attachment 348066 [details] WIP
Myles C. Maxfield
Comment 2 2018-08-27 16:26:14 PDT
We should make sure we test things like Texture2D<vector<float, 4>>
Myles C. Maxfield
Comment 3 2018-08-28 15:06:23 PDT
Created attachment 348347 [details] WIP
Myles C. Maxfield
Comment 4 2018-08-28 17:31:44 PDT
Created attachment 348365 [details] WIP
Myles C. Maxfield
Comment 5 2018-08-28 19:24:58 PDT
Created attachment 348376 [details] WIP
Myles C. Maxfield
Comment 6 2018-08-29 14:19:32 PDT
Created attachment 348433 [details] WIP
Myles C. Maxfield
Comment 7 2018-08-29 18:23:38 PDT
Created attachment 348459 [details] WIP
Myles C. Maxfield
Comment 8 2018-08-29 19:13:06 PDT
Created attachment 348464 [details] WIP
Myles C. Maxfield
Comment 9 2018-08-29 19:18:44 PDT
Created attachment 348467 [details] WIP
Myles C. Maxfield
Comment 10 2018-08-30 11:54:23 PDT
Created attachment 348521 [details] WIP
Myles C. Maxfield
Comment 11 2018-08-30 19:24:02 PDT
Created attachment 348581 [details] WIP
Myles C. Maxfield
Comment 12 2018-08-30 19:25:35 PDT
Created attachment 348582 [details] WIP
Myles C. Maxfield
Comment 13 2018-08-30 23:04:20 PDT
Created attachment 348607 [details] WIP
Myles C. Maxfield
Comment 14 2018-08-31 12:08:27 PDT
Created attachment 348661 [details] WIP
Myles C. Maxfield
Comment 15 2018-08-31 17:22:11 PDT
Created attachment 348687 [details] WIP
Myles C. Maxfield
Comment 16 2018-08-31 18:25:38 PDT
Created attachment 348695 [details] Can sample
Myles C. Maxfield
Comment 17 2018-08-31 19:42:10 PDT
Created attachment 348698 [details] Can sample
Myles C. Maxfield
Comment 18 2018-08-31 22:02:49 PDT
Created attachment 348705 [details] WIP
Myles C. Maxfield
Comment 19 2018-09-01 14:03:27 PDT
Created attachment 348717 [details] WIP
Myles C. Maxfield
Comment 20 2018-09-01 15:18:48 PDT
Created attachment 348718 [details] WIP
Myles C. Maxfield
Comment 21 2018-09-01 18:13:32 PDT
Created attachment 348723 [details] WIP
Myles C. Maxfield
Comment 22 2018-09-01 19:36:01 PDT
Created attachment 348724 [details] WIP
Myles C. Maxfield
Comment 23 2018-09-01 22:28:48 PDT
Created attachment 348726 [details] WIP
Myles C. Maxfield
Comment 24 2018-09-01 22:40:39 PDT
Created attachment 348727 [details] WIP
Myles C. Maxfield
Comment 25 2018-09-02 17:03:34 PDT
Created attachment 348752 [details] WIP
Myles C. Maxfield
Comment 26 2018-09-02 22:58:10 PDT
Created attachment 348758 [details] WIP
Myles C. Maxfield
Comment 27 2018-09-03 09:20:22 PDT
Created attachment 348775 [details] Cubemaps complete
Myles C. Maxfield
Comment 28 2018-09-03 15:23:56 PDT
Created attachment 348791 [details] Started gathering
Myles C. Maxfield
Comment 29 2018-09-03 17:06:15 PDT
Created attachment 348797 [details] Test gathering
Myles C. Maxfield
Comment 30 2018-09-03 17:33:39 PDT
Created attachment 348798 [details] Patch
Myles C. Maxfield
Comment 31 2018-09-03 19:51:49 PDT
Created attachment 348800 [details] Needs finishing touches
Myles C. Maxfield
Comment 32 2018-09-03 19:56:42 PDT
Created attachment 348801 [details] Needs tests for SampleCmpLevelZero
Myles C. Maxfield
Comment 33 2018-09-03 21:39:02 PDT
Created attachment 348804 [details] Patch
Dean Jackson
Comment 34 2018-09-04 11:31:25 PDT
Comment on attachment 348804 [details] Patch rs=me
Myles C. Maxfield
Comment 35 2018-09-04 14:18:30 PDT
Committed r235635: <https://trac.webkit.org/changeset/235635>
Radar WebKit Bug Importer
Comment 36 2018-09-04 14:19:20 PDT
<rdar://problem/44112106>
Myles C. Maxfield
Comment 37 2018-09-04 14:42:07 PDT
Committed r235642: <https://trac.webkit.org/changeset/235642>
Myles C. Maxfield
Comment 38 2018-10-13 19:13:46 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/89
Note You need to log in before you can comment on or make changes to this bug.