Bug 188916

Summary: [CoordGraphics] Move inline methods on CoordinatedGraphicsLayer out-of-line
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, ews-watchlist, kondapallykalyan, luiz, magomez, mcatanzaro, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188881
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-08-23 23:22:54 PDT
Should address this: > ERROR: > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer. > h:114: Inline functions should not be in classes annotated with > WEBCORE_EXPORT. Remove the macro from the class and apply it to each > appropriate method, or move the inline function definition out-of-line. > [build/webcore_export] [4] > Total errors found: 1 in 9 files
Attachments
Patch (3.69 KB, patch)
2018-08-23 23:25 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.53 KB, patch)
2018-08-24 00:55 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-08-23 23:25:46 PDT
Created attachment 347995 [details] Patch
Zan Dobersek
Comment 2 2018-08-24 00:55:16 PDT
Created attachment 347997 [details] Patch for landing Also out-lines the usesContentLayer() method.
Zan Dobersek
Comment 3 2018-08-24 02:13:49 PDT
Comment on attachment 347997 [details] Patch for landing Clearing flags on attachment: 347997 Committed r235314: <https://trac.webkit.org/changeset/235314>
Zan Dobersek
Comment 4 2018-08-24 02:13:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-08-24 02:14:16 PDT
<rdar://problem/43677220>
Note You need to log in before you can comment on or make changes to this bug.