Bug 188881

Summary: [CoordGraphics] Remove the remaining CoordinatedGraphicsLayerState cruft
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, ews-watchlist, magomez, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188916
Bug Depends on:    
Bug Blocks: 187385    
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2018-08-23 00:21:49 PDT
[CoordGraphics] Remove the remaining CoordinatedGraphicsLayerState cruft
Attachments
Patch (37.05 KB, patch)
2018-08-23 00:33 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (37.08 KB, patch)
2018-08-23 00:39 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-08-23 00:33:11 PDT
Created attachment 347915 [details] Patch
EWS Watchlist
Comment 2 2018-08-23 00:34:52 PDT
Attachment 347915 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2018-08-23 00:39:09 PDT
Created attachment 347916 [details] Patch
EWS Watchlist
Comment 4 2018-08-23 00:40:44 PDT
Attachment 347916 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 5 2018-08-23 05:34:39 PDT
Comment on attachment 347916 [details] Patch Clearing flags on attachment: 347916 Committed r235221: <https://trac.webkit.org/changeset/235221>
Zan Dobersek
Comment 6 2018-08-23 05:34:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-23 05:35:23 PDT
<rdar://problem/43640432>
Michael Catanzaro
Comment 8 2018-08-23 07:52:34 PDT
I think you need to fix this: (In reply to Build Bot from comment #4) > ERROR: > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer. > h:114: Inline functions should not be in classes annotated with > WEBCORE_EXPORT. Remove the macro from the class and apply it to each > appropriate method, or move the inline function definition out-of-line. > [build/webcore_export] [4] > Total errors found: 1 in 9 files
Zan Dobersek
Comment 9 2018-08-23 23:23:34 PDT
(In reply to Michael Catanzaro from comment #8) > I think you need to fix this: > > (In reply to Build Bot from comment #4) > > ERROR: > > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer. > > h:114: Inline functions should not be in classes annotated with > > WEBCORE_EXPORT. Remove the macro from the class and apply it to each > > appropriate method, or move the inline function definition out-of-line. > > [build/webcore_export] [4] > > Total errors found: 1 in 9 files Bug #188916.
Note You need to log in before you can comment on or make changes to this bug.