Bug 188738

Summary: [GTK] Sort inspector GResource manifest to ensure reproducible builds
Product: WebKit Reporter: Bernhard M. Wiedemann <webkitbmw>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fixing patch
aperez: review-
patch with changelog entry none

Bernhard M. Wiedemann
Reported 2018-08-19 21:57:40 PDT
bug 174540 occurred again in openSUSE's webkit2gtk3 package (even though webkitgtk and webkitgtk3 packages are dropped)
Attachments
fixing patch (871 bytes, patch)
2018-08-19 22:02 PDT, Bernhard M. Wiedemann 		aperez: review-
DetailsFormatted DiffDiff
patch with changelog entry (1.71 KB, patch)
2018-08-20 07:18 PDT, Bernhard M. Wiedemann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bernhard M. Wiedemann
Comment 1 2018-08-19 22:02:19 PDT
Created attachment 347480 [details] fixing patch
Adrian Perez
Comment 2 2018-08-20 02:42:35 PDT
Comment on attachment 347480 [details] fixing patch Hi Bernhard! I think it would be fine to merge the patchit, but it would need to follow the convention of including a ChangeLog entry. You can generate one for your changes using “Tools/Scripts/prepare-ChangeLog”. If you have a Git checkout, you can pass “-g <commitish>” to indicate for which commit(s) the entry will be generated. Could you please be so kind as to add the ChangeLog entry and re-submit the patch? Thanks in advance!
Bernhard M. Wiedemann
Comment 3 2018-08-20 07:18:57 PDT
Created attachment 347495 [details] patch with changelog entry
Michael Catanzaro
Comment 4 2018-08-20 07:21:52 PDT
Comment on attachment 347495 [details] patch with changelog entry In the future, you can use the r? and cq? flags to request review and commit, respectively.
WebKit Commit Bot
Comment 5 2018-08-20 09:49:17 PDT
Comment on attachment 347495 [details] patch with changelog entry Clearing flags on attachment: 347495 Committed r235080: <https://trac.webkit.org/changeset/235080>
WebKit Commit Bot
Comment 6 2018-08-20 09:49:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.