Bug 188517
| Summary: | [WHLSL] Verify the parser uses the same grammar as the language | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Thomas Denney <tdenney> |
| Component: | WebGPU | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED MOVED | ||
| Severity: | Normal | CC: | dino, jonlee, mmaxfield, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 176199, 189202 | ||
Thomas Denney
The current hand-written recursive-descent parser is relatively slow and is the main bottleneck of the `prepare` function. The parser should be rewritten using a tool that produces more efficient code, such as https://github.com/antlr/antlr4.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Myles C. Maxfield
*** Bug 189014 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
It takes 2.5 hours to compile the standard library. 95% of the time is spent parsing.
Myles C. Maxfield
One way to do this is by using a parser generator. Another way of doing this is with testing. Another way is via inspection.
Radar WebKit Bug Importer
<rdar://problem/44403020>
Myles C. Maxfield
Migrated to https://github.com/gpuweb/WHLSL/issues/101