Bug 188241

Summary: Make sure cookies get flushed to disk before exiting or suspending the network process
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177972    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2018-08-01 15:20:31 PDT 
Make sure cookies get flushed to disk before exiting or suspending the network process.
Comment 1 Chris Dumez 2018-08-01 15:24:55 PDT 
Created attachment 346306 [details]
Patch
Comment 2 EWS Watchlist 2018-08-01 15:26:27 PDT 
Attachment 346306 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:215:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2018-08-01 15:48:55 PDT 
<rdar://problem/42831831>
Comment 4 Chris Dumez 2018-08-01 15:55:45 PDT 
Comment on attachment 346306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346306&action=review

> Source/WebKit/Shared/ChildProcess.cpp:72
> +    WorkQueue::create("com.apple.WebKit.ChildProcess.WatchDogQueue")->dispatchAfter(watchdogDelay, [] {

This is a partial rollout of https://trac.webkit.org/changeset/231348/webkit to give the Network process a chance to sync cookies before exit.
Comment 5 Geoffrey Garen 2018-08-01 16:03:34 PDT 
r=me too
Comment 6 Chris Dumez 2018-08-01 16:03:58 PDT 
*** Bug 188236 has been marked as a duplicate of this bug. ***
Comment 7 Chris Dumez 2018-08-01 16:05:51 PDT 
Created attachment 346311 [details]
Patch
Comment 8 EWS Watchlist 2018-08-01 16:08:33 PDT 
Attachment 346311 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:215:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2018-08-01 16:45:51 PDT 
Comment on attachment 346311 [details]
Patch

Clearing flags on attachment: 346311

Committed r234486: <https://trac.webkit.org/changeset/234486>
Comment 10 WebKit Commit Bot 2018-08-01 16:45:52 PDT 
All reviewed patches have been landed.  Closing bug.