Bug 187331

Summary: [ews-build] WebKitPy-Tests-EWS should output result in json
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ddkilzer, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187148
https://bugs.webkit.org/show_bug.cgi?id=189417
Attachments:
Description Flags
Proposed patch ddkilzer: review+

Aakash Jain
Reported 2018-07-04 14:01:19 PDT
WebKitPy-Tests-EWS should output result in json format. This would be useful in easily parsing the errors.
Attachments
Proposed patch (2.75 KB, patch)
2018-07-04 14:04 PDT, Aakash Jain 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-07-04 14:04:40 PDT
Created attachment 344300 [details] Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/16/builds/26
David Kilzer (:ddkilzer)
Comment 2 2018-07-05 10:19:02 PDT
Comment on attachment 344300 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=344300&action=review r=me > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:313 > + command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'], > + logfiles={'json': 'webkitpy_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py. > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:326 > + command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'], > + logfiles={'json': 'webkitpy_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py.
Aakash Jain
Comment 3 2018-07-05 10:25:43 PDT
(In reply to David Kilzer (:ddkilzer) from comment #2) > Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done > in steps.py. Sure, will re-use the variable.
Aakash Jain
Comment 4 2018-07-05 10:26:51 PDT
Committed r233527: <https://trac.webkit.org/changeset/233527>.
Radar WebKit Bug Importer
Comment 5 2018-07-05 10:34:44 PDT
<rdar://problem/41853334>
Aakash Jain
Comment 6 2018-07-05 11:38:17 PDT
Committed r233528.
Note You need to log in before you can comment on or make changes to this bug.