Summary: | InstanceOf IC should do generic if the prototype is not an object. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Keith Miller
2018-07-02 09:36:55 PDT
Created attachment 344109 [details]
Patch
Comment on attachment 344109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344109&action=review r=me > Source/JavaScriptCore/jit/Repatch.cpp:743 > if (!jsDynamicCast<JSObject*>(vm, value)) { Fix this indentation. Comment on attachment 344109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344109&action=review >> Source/JavaScriptCore/jit/Repatch.cpp:743 >> if (!jsDynamicCast<JSObject*>(vm, value)) { > > Fix this indentation. Whoops, fixed. Created attachment 344113 [details]
Patch for landing
Comment on attachment 344113 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=344113&action=review > Source/JavaScriptCore/ChangeLog:3 > + InstanceOf IC should do generic if the prototype is not an object. do generic => go generic Comment on attachment 344113 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=344113&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + InstanceOf IC should do generic if the prototype is not an object. > > do generic => go generic I don't think that's accurate since you can still have Hit/Miss cases even with a generic case. I'm just talking about the english of your title. "Generic" is not a thing you "do". Perhaps "become" is the right word The commit-queue encountered the following flaky tests while processing attachment 344113 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 344113 [details] Patch for landing Clearing flags on attachment: 344113 Committed r233427: <https://trac.webkit.org/changeset/233427> All reviewed patches have been landed. Closing bug. |