Bug 187113

Summary: Don't invoke post resolution callbacks when resolving computed style
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, tsavell
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187156
Attachments:
Description Flags
patch
ggaren: review+
patch none

Antti Koivisto
Reported 2018-06-27 12:49:44 PDT
Post resolution callbacks should only be invoked when we actually resolve the document style.
Attachments
patch (8.86 KB, patch)
2018-06-27 13:17 PDT, Antti Koivisto 		ggaren: review+
DetailsFormatted DiffDiff
patch (8.31 KB, patch)
2018-06-27 13:46 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-06-27 12:50:17 PDT
<rdar://problem/41365766>
Antti Koivisto
Comment 2 2018-06-27 13:17:32 PDT
Created attachment 343745 [details] patch
Geoffrey Garen
Comment 3 2018-06-27 13:23:37 PDT
Comment on attachment 343745 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=343745&action=review r=me > LayoutTests/ChangeLog:24 > +2018-06-15 Antti Koivisto <antti@apple.com> > + > + Semantic colors should not be transformed by color-filter > + https://bugs.webkit.org/show_bug.cgi?id=186566 > + <rdar://problem/40705739> > + > + Reviewed by NOBODY (OOPS!). > + > + * css3/color-filters/color-filter-ignore-semantic-expected.html: Added. > + * css3/color-filters/color-filter-ignore-semantic.html: Added. > + Revert please.
Antti Koivisto
Comment 4 2018-06-27 13:46:44 PDT
Created attachment 343749 [details] patch
WebKit Commit Bot
Comment 5 2018-06-27 15:25:37 PDT
Comment on attachment 343749 [details] patch Clearing flags on attachment: 343749 Committed r233281: <https://trac.webkit.org/changeset/233281>
WebKit Commit Bot
Comment 6 2018-06-27 15:25:39 PDT
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 7 2018-06-28 10:34:12 PDT
it looks like after revision 233281 we started getting consistent timeouts on tests. Tests Timeout: fast/dom/location-new-window-no-crash.html http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html storage/indexeddb/modern/blob-cursor.html storage/indexeddb/modern/blob-svg-image.html failure report: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r233306%20(5312)/results.html
Antti Koivisto
Comment 8 2018-06-28 14:22:37 PDT
https://bugs.webkit.org/show_bug.cgi?id=187156 for that
Note You need to log in before you can comment on or make changes to this bug.