Bug 187014

Summary: [ews-build] Add support for Bindings-tests-EWS
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187023
https://bugs.webkit.org/show_bug.cgi?id=187330
Attachments:
Description Flags
Proposed patch lforschler: review+

Aakash Jain
Reported 2018-06-25 13:52:24 PDT
We should add support for Binding-tests-EWS.
Attachments
Proposed patch (3.75 KB, patch)
2018-06-25 13:57 PDT, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-06-25 13:57:49 PDT
Created attachment 343535 [details] Proposed patch
EWS Watchlist
Comment 2 2018-06-25 14:00:50 PDT
Attachment 343535 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247: [TestRunBindingsTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247: [TestRunBindingsTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259: [TestRunBindingsTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259: [TestRunBindingsTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Aakash Jain
Comment 3 2018-06-25 14:03:14 PDT
This is similar to what we use in other Buildbot code. Also tested on ews-build.webkit-uat.org (http://ews-build.webkit-uat.org/#/builders/14/builds/5)
Aakash Jain
Comment 4 2018-06-25 14:03:58 PDT
style-queue warnings are false positive.
Aakash Jain
Comment 5 2018-06-25 14:28:51 PDT
Committed r233175: <https://trac.webkit.org/changeset/233175>
Radar WebKit Bug Importer
Comment 6 2018-06-25 14:31:10 PDT
<rdar://problem/41440190>
Note You need to log in before you can comment on or make changes to this bug.