Bug 186961

Summary: [Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, dbates, ddkilzer, ews-watchlist, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221107, 221108    
Attachments:
Description Flags
Patch andersca: review+

Darin Adler
Reported 2018-06-22 21:44:45 PDT
[Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC
Attachments
Patch (4.36 KB, patch)
2018-06-22 21:45 PDT, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-06-22 21:45:38 PDT
Created attachment 343419 [details] Patch
Darin Adler
Comment 2 2018-06-23 08:30:40 PDT
Committed r233128: <https://trac.webkit.org/changeset/233128>
Radar WebKit Bug Importer
Comment 3 2018-06-23 08:31:21 PDT
<rdar://problem/41398383>
David Kilzer (:ddkilzer)
Comment 4 2018-07-01 15:36:29 PDT
Comment on attachment 343419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343419&action=review > Source/WTF/Configurations/Base.xcconfig:36 > +CLANG_ENABLE_OBJC_ARC = YES; > CLANG_ENABLE_OBJC_WEAK = YES; Note that you can remove "CLANG_ENABLE_OBJC_WEAK = YES;" when enabling ARC, as -fobjc-arc is a superset of -fobjc-weak.
mitz
Comment 5 2018-07-01 15:39:22 PDT
(In reply to David Kilzer (:ddkilzer) from comment #4) > Comment on attachment 343419 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343419&action=review > > > Source/WTF/Configurations/Base.xcconfig:36 > > +CLANG_ENABLE_OBJC_ARC = YES; > > CLANG_ENABLE_OBJC_WEAK = YES; > > Note that you can remove "CLANG_ENABLE_OBJC_WEAK = YES;" when enabling ARC, > as -fobjc-arc is a superset of -fobjc-weak. See bug 186396 comment 2 and my response.
Note You need to log in before you can comment on or make changes to this bug.