Bug 186560

Summary:

[GTK][WPE] WebDriver: handle acceptInsecureCertificates capability

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebDriver

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, berto, bugs-noreply, calvaris, ews-watchlist, gustavo, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer, zan

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=186557

Attachments:

Description	Flags
Patch	none
Patch	bburg: review-, ews-watchlist: commit-queue-
Archive of layout-test-results from ews202 for win-future	none
Updated patch	bburg: review+

Carlos Garcia Campos

Reported 2018-06-12 05:39:05 PDT

We currently process the capability, but it's not sent to the browser so it's actually ignored.

Attachments
Patch (22.92 KB, patch) 2018-06-12 05:47 PDT, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Patch (23.23 KB, patch) 2018-06-12 05:55 PDT, Carlos Garcia Campos	bburg: review- ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews202 for win-future (12.99 MB, application/zip) 2018-06-12 08:24 PDT, EWS Watchlist	no flags	Details
Updated patch (23.30 KB, patch) 2018-06-12 23:45 PDT, Carlos Garcia Campos	bburg: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2018-06-12 05:47:45 PDT

Created attachment 342526 [details] Patch

EWS Watchlist

Comment 2 2018-06-12 05:49:20 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Carlos Garcia Campos

Comment 3 2018-06-12 05:55:10 PDT

Created attachment 342527 [details] Patch

EWS Watchlist

Comment 4 2018-06-12 08:23:58 PDT

Comment on attachment 342527 [details] Patch Attachment 342527 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8147166 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html http/tests/preload/onload_event.html

EWS Watchlist

Comment 5 2018-06-12 08:24:10 PDT

Created attachment 342537 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Blaze Burg

Comment 6 2018-06-12 16:10:44 PDT

Comment on attachment 342527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342527&action=review Everything else looks fine except the issue noted. > Source/WebDriver/ChangeLog:9 > + cabaility is sent. Nit: capability > Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:89 > + dispatch_async(dispatch_get_main_queue(), ^{ r- because this causes a UAF (which I only caught by applying manually and running tests ;-)). You need to do the following outside the block: NSString *requestedSessionIdentifier = sessionIdentifier; then use that NSString as the argument rather than applying the type conversion inside the block. The WTFString may no longer be around at that time.

Carlos Garcia Campos

Comment 7 2018-06-12 23:45:32 PDT

Created attachment 342639 [details] Updated patch

Blaze Burg

Comment 8 2018-06-13 08:35:07 PDT

Comment on attachment 342639 [details] Updated patch r=me

Carlos Garcia Campos

Comment 9 2018-06-14 00:23:53 PDT

Committed r232833: <https://trac.webkit.org/changeset/232833>

Radar WebKit Bug Importer

Comment 10 2018-06-14 00:25:14 PDT

<rdar://problem/41117014>

Note You need to log in before you can comment on or make changes to this bug.