| Summary: | [GTK][WPE] MiniBrowsers should be able to ignore TLS errors | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, clopez, ews-watchlist, glenn, mcatanzaro, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=186560 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2018-06-12 01:44:06 PDT
Created attachment 342522 [details]
Patch
Comment on attachment 342522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342522&action=review > Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:42 > - return ['--automation', '--javascript-can-open-windows-automatically=true', '--enable-xss-auditor=false'] > + return ['--automation', '--javascript-can-open-windows-automatically=true', > + '--enable-xss-auditor=false', '--ignore-tls-errors=true'] I don't think we should do this here. We should implement and use acceptInsecureCerts capability instead. If we send this capability as part of the StartAutomationSession message, we can handle it internally without having to add an option to MiniBrowser and it will work with any browser. That's what I planned to do for the proxy capabilities. Bug #186560 is what I meant, but I'm not sure we will be able to use that approach in the end, because w3c tests don't allow to pass capabilities that are also added by the tests themselves. If we can't change the w3c tests behavior, then the patch attached here would be the only way, I think. Created attachment 342728 [details]
Patch
Attachment 342728 [details] did not pass style-queue:
ERROR: Tools/MiniBrowser/wpe/main.cpp:53: Use nullptr instead of NULL. [readability/null] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 342728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342728&action=review Thanks! > Tools/MiniBrowser/wpe/main.cpp:53 > + { "ignore-tls-errors", 0, 0, G_OPTION_ARG_NONE, &ignoreTLSErrors, "Ignore TLS errors", NULL }, Use nullptr here, WPE MiniBrowser is c++ not c. Committed r232834: <https://trac.webkit.org/changeset/232834> |