Bug 186403

Summary: [webkitpy] Treat svn versions as Version objects
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ddkilzer, ews-watchlist, glenn, lforschler, mitz, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186404
https://bugs.webkit.org/show_bug.cgi?id=186401
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2018-06-07 11:53:34 PDT
Seems like webkit-patch is generating diffs in a weird way with an svn checkout on Mojave seed 1. svn-create-patch works just fine, so the root of the problem is somewhere in webkit-patch.
Attachments
Patch (3.91 KB, patch)
2018-06-07 15:43 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-07 11:57:55 PDT
<rdar://problem/40904860>
Jonathan Bedard
Comment 2 2018-06-07 15:07:31 PDT
Looks like there are a few other svn problems in Mojave too, revealed by running 'test-webkitpy --all'.
Jonathan Bedard
Comment 3 2018-06-07 15:43:46 PDT
Created attachment 342213 [details] Patch
WebKit Commit Bot
Comment 4 2018-06-07 16:15:47 PDT
Comment on attachment 342213 [details] Patch Clearing flags on attachment: 342213 Committed r232605: <https://trac.webkit.org/changeset/232605>
WebKit Commit Bot
Comment 5 2018-06-07 16:15:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.