Bug 186335

Summary: Add Accept-Encoding: identity to Range requests
Product: WebKit Reporter: Jake Archibald <jaffathecake>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, dbates, eric.carlson, ews-watchlist, japhet, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jake Archibald
Reported 2018-06-05 20:19:21 PDT
Spec change: https://github.com/whatwg/fetch/pull/751 Tests: https://github.com/web-platform-tests/wpt/pull/11291 Turns out a significant number of servers ignore Range headers unless "Accept-Encoding: identity" is set. This spec change applies that header to all requests with a Range header. Safari already does this for media requests, although the header is applied before the service worker, when it should be afterwards. Related issues: https://bugs.webkit.org/show_bug.cgi?id=186050 https://bugs.webkit.org/show_bug.cgi?id=184447
Attachments
Patch (34.70 KB, patch)
2018-06-06 10:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (34.77 KB, patch)
2018-06-06 20:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-05 21:58:26 PDT
<rdar://problem/40837190>
youenn fablet
Comment 2 2018-06-06 10:15:51 PDT
Created attachment 342056 [details] Patch
Eric Carlson
Comment 3 2018-06-06 11:44:53 PDT
Comment on attachment 342056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342056&action=review > Source/WebCore/loader/cache/CachedResourceRequest.cpp:214 > + // FIXME: We should ask the media engine to not set this header. Please file a Radar and include the number here.
youenn fablet
Comment 4 2018-06-06 20:23:00 PDT
Created attachment 342113 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-06-06 21:03:37 PDT
Comment on attachment 342113 [details] Patch for landing Clearing flags on attachment: 342113 Committed r232571: <https://trac.webkit.org/changeset/232571>
WebKit Commit Bot
Comment 6 2018-06-06 21:03:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.