Bug 186103

Summary: [iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWillAppear:]
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: MediaAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jeremyj-wk, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 186067    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2018-05-30 11:02:58 PDT
Fix static analyzer warnings in WKFullScreenViewController.mm: Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:70:13: warning: Called C++ object pointer is null interface->playbackSessionModel()->removeClient(*this); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:306:1: warning: The 'viewWillAppear:' instance method in UIViewController subclass 'WKFullScreenViewController' is missing a [super viewWillAppear:] call } ^ 2 warnings generated.
Attachments
Patch v1 (2.25 KB, patch)
2018-05-30 11:10 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.00 KB, patch)
2018-05-30 11:21 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-30 11:03:26 PDT
<rdar://problem/40655695>
David Kilzer (:ddkilzer)
Comment 2 2018-05-30 11:10:27 PDT
Created attachment 341584 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2018-05-30 11:18:33 PDT
Jer fixed the first issue in: Bug 186067: Fix a few issues in WKFullScreenViewController <https://bugs.webkit.org/show_bug.cgi?id=186067> <https://trac.webkit.org/changeset/232299> Updating this just to fix the -viewWillAppear: issue.
David Kilzer (:ddkilzer)
Comment 4 2018-05-30 11:21:28 PDT
Created attachment 341585 [details] Patch v2
WebKit Commit Bot
Comment 5 2018-05-30 13:41:12 PDT
Comment on attachment 341585 [details] Patch v2 Clearing flags on attachment: 341585 Committed r232308: <https://trac.webkit.org/changeset/232308>
WebKit Commit Bot
Comment 6 2018-05-30 13:41:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.